Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a struct for GetStatus to be consistent #731

Merged
merged 1 commit into from May 30, 2019
Merged

Use a struct for GetStatus to be consistent #731

merged 1 commit into from May 30, 2019

Conversation

johnSchnake
Copy link
Contributor

What this PR does / why we need it:
Increases consistency of our method signatures for the interface.

Which issue(s) this PR fixes
Fixes #337

Special notes for your reviewer:

Release note:

The GetStatus method on the pkg/Interface (and SonobuoyClient type) will now take a struct which wraps the namespaces to increase in consistency and future extensibility.

Fixes #337

Signed-off-by: John Schnake <jschnake@vmware.com>
@johnSchnake
Copy link
Contributor Author

Small PR to just get the item off of our backlog. Merging.

@johnSchnake johnSchnake merged commit cfd9cfc into vmware-tanzu:master May 30, 2019
@johnSchnake johnSchnake deleted the statusconfig branch May 30, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be consistent about what we pass into the Interface methods
1 participant