Default to ResultFormat=raw if unset #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unset (or invalid), currently no post-processing is done which means that users won't find the sonobuoy_results.yaml file. By defaulting to 'raw' we make users immediately get a benefit from the post-processing regardless of if they take extra steps to customize the type/output. Fixes #820 Signed-off-by: John Schnake <jschnake@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 44.45% 44.49% +0.03%
==========================================
Files 76 76
Lines 4618 4619 +1
==========================================
+ Hits 2053 2055 +2
+ Misses 2432 2431 -1
Partials 133 133
Continue to review full report at Codecov.
|
zubron
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When unset (or invalid), currently no post-processing is done which
means that users won't find the sonobuoy_results.yaml file.
By defaulting to 'raw' we make users immediately get a benefit from
the post-processing regardless of if they take extra steps to
customize the type/output.
Which issue(s) this PR fixes
Fixes #820
Special notes for your reviewer:
Release note: