Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Activating plugins on Plugin Group Publish/Activation #794

Merged

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jul 12, 2024

What this PR does / why we need it

There might be a use case where teams want to publish their plugins to the production in a deactivated state and only enable the plugins as part of the PluginGroup publishing process when thePluginGroup is Activated.

This PR supports this use case by exposing the TANZU_CLI_ACTIVATE_PLUGINS_ON_PLUGIN_GROUP_PUBLISH environment variable. If this environment variable is set to true as part of plugin group publishing or plugin group activation it will also activate the plugins within the plugin group.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • Added Unit Tests
  • Manual tests

Release note

Support Activating plugins on Plugin Group Publish/Activation

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner July 12, 2024 21:27
@anujc25 anujc25 force-pushed the support-activating-plugin-on-pg-publish branch from c1eedea to f48bbb5 Compare July 12, 2024 21:35
@marckhouzam marckhouzam modified the milestone: v1.4.0 Jul 15, 2024
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new feature!

pkg/constants/env_variables.go Show resolved Hide resolved
pkg/plugininventory/sqlite_inventory.go Show resolved Hide resolved
pkg/plugininventory/sqlite_inventory.go Outdated Show resolved Hide resolved
pkg/plugininventory/sqlite_inventory.go Show resolved Hide resolved
pkg/plugininventory/sqlite_inventory.go Outdated Show resolved Hide resolved
pkg/plugininventory/sqlite_inventory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for thinking of add this feature @anujc25. It will save time to many plugin developers.

@marckhouzam marckhouzam added this to the v1.4.0 milestone Jul 16, 2024
@anujc25 anujc25 merged commit 9451a9a into vmware-tanzu:main Jul 16, 2024
7 checks passed
anujc25 added a commit that referenced this pull request Jul 18, 2024
* Support activating plugins on plugin group publish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants