Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS_PROFILE for restic backups/restore operations #2096

Merged
merged 3 commits into from Dec 9, 2019

Conversation

@dinesh
Copy link
Contributor

dinesh commented Dec 3, 2019

Fixes #2033

It enables Velero to switch credentials if multiple s3-compatible backupLocations are present.

It enables Velero to switch credentials if multiple s3-compatible
backupLocations are present.

Signed-off-by: dinesh <dinesh1042@gmail.com>
Copy link
Member

skriss left a comment

couple of nitpicks, but mostly LGTM @dinesh! I'll see if I can test as well.

pkg/restic/aws.go Outdated Show resolved Hide resolved
pkg/restic/common.go Outdated Show resolved Hide resolved
Signed-off-by: dinesh <dinesh1042@gmail.com>
@dinesh

This comment has been minimized.

Copy link
Contributor Author

dinesh commented Dec 5, 2019

@skriss tried incorporating your comments, please have a look.

@skriss

This comment has been minimized.

Copy link
Member

skriss commented Dec 5, 2019

thanks for the updates!

@skriss

This comment has been minimized.

Copy link
Member

skriss commented Dec 5, 2019

I haven't actually tested, but the code LGTM and @dinesh has tested successfully.

@dinesh can you also add a changelog for this PR? See https://velero.io/docs/master/code-standards/ for details.

Signed-off-by: dinesh <dinesh1042@gmail.com>
@dinesh

This comment has been minimized.

Copy link
Contributor Author

dinesh commented Dec 6, 2019

@skriss added.

@skriss skriss requested review from carlisia, nrb and prydonius Dec 6, 2019
@skriss

This comment has been minimized.

Copy link
Member

skriss commented Dec 6, 2019

@skriss
skriss approved these changes Dec 6, 2019
@nrb nrb merged commit 83ef4eb into vmware-tanzu:master Dec 9, 2019
7 checks passed
7 checks passed
Header rules - velero No header rules processed
Details
Pages changed - velero 790 new files uploaded
Details
Redirect rules - velero No redirect rules processed
Details
DCO DCO
Details
Mixed content - velero No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/velero/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.