From 7175283b199e00858800dab2dcce462a78683615 Mon Sep 17 00:00:00 2001 From: Lyndon-Li Date: Thu, 8 Jun 2023 12:17:49 +0800 Subject: [PATCH] change kopia as the default path of PVB Signed-off-by: Lyndon-Li --- changelogs/unreleased/6370-Lyndon-Li | 1 + .../unified-repo-and-kopia-integration.md | 7 +++---- pkg/cmd/cli/install/install.go | 2 +- site/content/docs/main/file-system-backup.md | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 changelogs/unreleased/6370-Lyndon-Li diff --git a/changelogs/unreleased/6370-Lyndon-Li b/changelogs/unreleased/6370-Lyndon-Li new file mode 100644 index 0000000000..5a4ff124cb --- /dev/null +++ b/changelogs/unreleased/6370-Lyndon-Li @@ -0,0 +1 @@ +Change kopia as the default path of PVB \ No newline at end of file diff --git a/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md b/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md index 7bef16df89..9790052f79 100644 --- a/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md +++ b/design/unified-repo-and-kopia-integration/unified-repo-and-kopia-integration.md @@ -337,10 +337,9 @@ Therefore, for the new path, Velero uses the information in the BackupStorageLoc The legacy path will be kept as is. That is, Velero still sets/gets the repoIdentififer in BackupRepository CRs, PodVolume Backup CRs and PodVolume Restore CRs and then passes to Restic CLI. ## Installation - We will add a new flag "--pod-volume-backup-uploader" during installation. The flag has 3 meanings: - - It indicates PodVolume BR as the default method to protect PV data over other methods, i.e., durable snapshot. Therefore, the existing --use-restic option will be replaced + We will add a new flag "--uploader-type" during installation. The flag has 2 meanings: - It indicates the file system uploader to be used by PodVolume BR - - It implies the backup repository type manner, Restic if pod-volume-backup-uploader=restic, Unified Repository in all other cases + - It implies the backup repository type manner, Restic if uploader-type=restic, Unified Repository in all other cases The flag has below two values: **"Restic"**: it means Velero will use Restic to do the pod volume backup. Therefore, the Velero server deployment will be created as below: @@ -470,7 +469,7 @@ Below sample files demonstrate complete CRs with all the changes mentioned above ## User Perspective This design aims to provide a flexible backup repository layer and a generic file system uploader, which are fundermental for PodVolume and other data movements. Although this will make Velero more capable, at present, we don't pursue to expose differentiated features end to end. Specifically: -- By default, Velero still uses Restic for PodVolume BR +- For a fresh installation, if the "--uploader-type" is not specified, there is a default value for PodVolume BR. We will keep it as "restic" for at least one release, then we switch the value to "kopia" - Even when changing to the new path, Velero still allows users to restore from the data backed up by Restic - The capability of PodVolume BR under the new path is kept the same as it under Restic path and the same as the existing PodVolume BR - The operational experiences are kept the same as much as possible, the known changes are listed below diff --git a/pkg/cmd/cli/install/install.go b/pkg/cmd/cli/install/install.go index d81f1a4d87..95f3297936 100644 --- a/pkg/cmd/cli/install/install.go +++ b/pkg/cmd/cli/install/install.go @@ -143,7 +143,7 @@ func NewInstallOptions() *Options { NoDefaultBackupLocation: false, CRDsOnly: false, DefaultVolumesToFsBackup: false, - UploaderType: uploader.ResticType, + UploaderType: uploader.KopiaType, } } diff --git a/site/content/docs/main/file-system-backup.md b/site/content/docs/main/file-system-backup.md index 881747895c..89c43ce7b7 100644 --- a/site/content/docs/main/file-system-backup.md +++ b/site/content/docs/main/file-system-backup.md @@ -521,7 +521,7 @@ refer to [restic integration](#how-velero-integrates-with-restic) and [kopia int Velero's FSB supports two data movement paths, the restic path and the kopia path. Velero allows users to select between the two paths: - For backup, the path is specified at the installation time through the `uploader-type` flag, the valid value is -either `restic` or `kopia`, or default to `restic` if the value is not specified. The selection is not allowed to be +either `restic` or `kopia`, or default to `kopia` if the value is not specified. The selection is not allowed to be changed after the installation. - For restore, the path is decided by the path used to back up the data, it is automatically selected. For example, if you've created a backup with restic path, then you reinstall Velero with `uploader-type=kopia`, when you create