From f67b99aca2efdc8b9a7bd437402dce89688c7ced Mon Sep 17 00:00:00 2001 From: Diane Wang Date: Wed, 13 Dec 2023 03:31:20 +0000 Subject: [PATCH] address comments Signed-off-by: Diane Wang --- windows/guest_customization/check_autologon_count.yml | 6 ++++-- windows/guest_customization/gosc_sanity_dhcp.yml | 4 ++-- windows/guest_customization/gosc_sanity_staticip.yml | 4 ++-- windows/guest_customization/win_gosc_prepare.yml | 2 +- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/windows/guest_customization/check_autologon_count.yml b/windows/guest_customization/check_autologon_count.yml index 3c0e62f66..53432b8e3 100644 --- a/windows/guest_customization/check_autologon_count.yml +++ b/windows/guest_customization/check_autologon_count.yml @@ -22,9 +22,11 @@ - name: "Check logon as Administrator automatically is enabled" ansible.builtin.assert: that: - - "{{ auto_admin_logon | int == 1 }}" + - auto_admin_logon | int == 1 success_msg: "Logon as Administrator automatically is enabled in guest OS." - fail_msg: "Logon as Administrator automatically registry value '{{ auto_admin_logon }}' is not equal to 1." + fail_msg: >- + Logon as Administrator automatically is not enabled in guest OS, + got registry value '{{ auto_admin_logon }}', not expected value 1. - name: "Get number of times to logon as Administrator automatically" ansible.windows.win_shell: >- diff --git a/windows/guest_customization/gosc_sanity_dhcp.yml b/windows/guest_customization/gosc_sanity_dhcp.yml index c404754d2..d38c82537 100644 --- a/windows/guest_customization/gosc_sanity_dhcp.yml +++ b/windows/guest_customization/gosc_sanity_dhcp.yml @@ -2,7 +2,7 @@ # SPDX-License-Identifier: BSD-2-Clause --- # Description: -# This test case is used for check guest OS customization (GOSC) +# This test case is used for checking guest OS customization (GOSC) # with DHCP network configuration. If VMware Tools is not installed, # the test result is 'Blocked'. # Note: VM guest OS customization requires vCenter server. @@ -13,5 +13,5 @@ vars: gosc_network_type: "dhcp" tasks: - - name: "GOSC test with DHCP network configure" + - name: "GOSC test with DHCP network configuration" include_tasks: win_gosc_workflow.yml diff --git a/windows/guest_customization/gosc_sanity_staticip.yml b/windows/guest_customization/gosc_sanity_staticip.yml index f4d94e8b6..b602699c2 100644 --- a/windows/guest_customization/gosc_sanity_staticip.yml +++ b/windows/guest_customization/gosc_sanity_staticip.yml @@ -2,7 +2,7 @@ # SPDX-License-Identifier: BSD-2-Clause --- # Description: -# This test case is used for check guest OS customization (GOSC) +# This test case is used for checking guest OS customization (GOSC) # with static network configuration. If VMware Tools is not installed, # the test result is 'Blocked'. # Note: VM guest OS customization requires vCenter server. @@ -13,5 +13,5 @@ vars: gosc_network_type: "static" tasks: - - name: "GOSC test with static network configure" + - name: "GOSC test with static network configuration" include_tasks: win_gosc_workflow.yml diff --git a/windows/guest_customization/win_gosc_prepare.yml b/windows/guest_customization/win_gosc_prepare.yml index 26a9d43e4..4049ed4c3 100644 --- a/windows/guest_customization/win_gosc_prepare.yml +++ b/windows/guest_customization/win_gosc_prepare.yml @@ -104,7 +104,7 @@ - name: "Decrypt Bitlocker volumes" include_tasks: ../utils/win_decrypt_bitlocker_volume.yml -- name: "Shutdown guest OS before execute GOSC" +- name: "Shutdown guest OS before executing GOSC" include_tasks: ../utils/win_shutdown_restart.yml vars: set_win_power_state: "shutdown"