This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(icons): fixing a11y issues related to icons in core #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• removed legacy architecture tying the svg to the icon component via aria-labelledBy • replaced legacy architecture with aria-labelling on the icon component • set icon component role to image • hid the underlying svg inside the icon with aria-hidden because screen readers were "double announcing" it • fixed unit tests in icons and alerts that were broken by new architecture and still relevant • updated icon stories to demonstrate accessible use of icons • fixed 'dir' attr in icons api story to use 'direction' • verified in voiceover Signed-off-by: Scott Mathis <smathis@vmware.com>
hippee-lee
approved these changes
Nov 3, 2020
bdryanovski
approved these changes
Nov 3, 2020
mathisscott
added
resolution: fixed
and removed
priority: 4 medium-high
status: in progress
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• removed legacy architecture tying the svg to the icon component via aria-labelledBy
• replaced legacy architecture with aria-labelling on the icon component
• set icon component role to image
• hid the underlying svg inside the icon with aria-hidden because screen readers were "double announcing" it
• fixed unit tests in icons and alerts that were broken by new architecture and still relevant
• updated icon stories to demonstrate accessible use of icons
• fixed 'dir' attr in icons api story to use 'direction'
• verified in voiceover
Signed-off-by: Scott Mathis smathis@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Icons in a screen reader are confusing.
Issue Number: N/A
What is the new behavior?
Icons in a screen reader make sense now.
Does this PR introduce a breaking change?
Other information
CC: @scroniser