New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] datepicker fixes #2988

Merged
merged 6 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@coryrylan
Copy link
Contributor

coryrylan commented Jan 3, 2019

  • After date selected by user refocus the input.

  • If updating the value from user then programmatically and back to the user, the output event
    should fire properly for two way binding.

closes #2792

closes #2993

Signed-off-by: Cory Rylan crylan@vmware.com

@coryrylan coryrylan self-assigned this Jan 3, 2019

coryrylan added some commits Jan 3, 2019

[NG] fix a11y issue with datepicker focus
After date selected by user refocus the input

closes #2792

Signed-off-by: Cory Rylan <crylan@vmware.com>
[NG] minor refactor date input directive
Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan force-pushed the coryrylan:topic/datepicker-focus branch from 57f5e1f to b7ebc31 Jan 3, 2019

[NG] fix datepicker value update
Emit value when switching between programmatic updates and user updates.

closes #2993

Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan changed the title [NG] fix a11y issue with datepicker focus [NG] datepicker fixes Jan 5, 2019

@youdz
Copy link
Contributor

youdz left a comment

I like the small clean-ups here and there while fixing the actual bugs. Good initiative. 👍

I have to admit I'm starting to get really, really lost in the data flow within the datepicker. There are a ton of methods with veryLongNamesThatDontReallyHelp so even if you know what each method does, figuring out the 10-levels-deep call stack when a consumer gives us an @Input or when the user starts typing is extremely tedious, manually going through the whole code step by step. 😥
After a quick investigation I think this fix for the second bug (the missing output) works, but I'm clearly relying on unit tests more than usual to ship this.

Great unit tests. 👍

@vmwclabot

This comment has been minimized.

Copy link
Member

vmwclabot commented Jan 8, 2019

@coryrylan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

fix golden file
Signed-off-by: Cory Rylan <crylan@vmware.com>
@vmwclabot

This comment has been minimized.

Copy link
Member

vmwclabot commented Jan 8, 2019

@coryrylan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@youdz

youdz approved these changes Jan 8, 2019

@vmwclabot

This comment has been minimized.

Copy link
Member

vmwclabot commented Jan 8, 2019

@coryrylan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@coryrylan coryrylan merged commit 278e0fa into vmware:master Jan 8, 2019

1 of 2 checks passed

deploy/netlify Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnomeontherun gnomeontherun added this to the 1.0.4 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment