New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix layout issues with datepicker and grid columns #2989

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@gnomeontherun
Copy link
Contributor

gnomeontherun commented Jan 3, 2019

This is actually a multipart bug. First, the datepicker didn't add clr-row to the container. Secondly, some places used clr-col-xs-12 with the grid, which is actually not correct as it should be clr-col-12. Finally, the input buttons are now consistently sized (datepicker calendar icon, password eye).

I've also added a few more gemini tests for alignment of form controls.

fixes #2983 #2970 #2968

gnomeontherun added some commits Jan 3, 2019

fix layout issues with datepicker and grid columns
This is actually a multipart bug. First, the datepicker didn't add `clr-row` to the container. Secondly, some places used `clr-col-xs-12` with the grid, which is actually not correct as it should be `clr-col-12`. Finally, the input buttons are now consistently sized (datepicker calendar icon, password eye).

fixes #2983 #2970

Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
fix tests
Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

@gnomeontherun gnomeontherun self-assigned this Jan 4, 2019

@youdz

youdz approved these changes Jan 7, 2019

Copy link
Contributor

youdz left a comment

Looks ok to me.

@gnomeontherun gnomeontherun merged commit 44be535 into vmware:master Jan 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@gnomeontherun gnomeontherun added this to the 1.0.4 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment