New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fix wizard modal height in Firefox (#3007) #3013

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@Jinnie
Copy link
Contributor

Jinnie commented Jan 10, 2019

Added content to the dev page and reduced window size of the geminy test so we force a scroll on tested content. I think it's enough to make sure we're not breaking Chrome. Firefox was tested manually.

Signed-off-by: Ivan Donchev idonchev@vmware.com

[UI] Fix wizard modal height in Firefox (#3007)
Added content to the dev page and reduced window size of the geminy test so we force a scroll on tested content. I think it's enough.

Signed-off-by: Ivan Donchev <idonchev@vmware.com>
@Shijir

Shijir approved these changes Jan 10, 2019

Copy link
Contributor

Shijir left a comment

LGTM. I assume this change has been tested manually on other browsers as well, right? :)

update after Edge issue /thanks Shijir! and tests updated
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
@Jinnie

This comment has been minimized.

Copy link
Contributor Author

Jinnie commented Jan 11, 2019

Very good point @Shijir ,
I had not tested it with MS browsers and there was a regression in Edge. Strange enough - IE11 looked fine :)
Adding the fix soon, thanks!!

@youdz

youdz approved these changes Jan 14, 2019

@Jinnie Jinnie merged commit e9118a6 into vmware:master Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@Jinnie Jinnie deleted the Jinnie:topic/ff-wizard-bug branch Jan 23, 2019

@Jinnie Jinnie added this to the 1.0.5 milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment