New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] fix input reset on datepicker/refactor #3050

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@coryrylan
Copy link
Contributor

coryrylan commented Jan 16, 2019

When using clrDate input, setting input to null would not clear the input.

closes #3012

Signed-off-by: Cory Rylan crylan@vmware.com

[NG] refactor date input, add tests
Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan self-assigned this Jan 16, 2019

@gnomeontherun gnomeontherun self-requested a review Jan 18, 2019

@youdz

youdz approved these changes Jan 18, 2019

Copy link
Contributor

youdz left a comment

Such a big diff for a pretty small changes, but this looks good to me. As usual, thanks for the incremental clean-ups.

Show resolved Hide resolved src/clr-angular/forms/datepicker/utils/date-utils.spec.ts
this.writeInitialInputFromUserInputField();
this.subscriptions.push(
this.listenForUserSelectedDayChanges(),
this.listenForControlValueChanges(),

This comment has been minimized.

@youdz

youdz Jan 18, 2019

Contributor

👍

@gnomeontherun
Copy link
Contributor

gnomeontherun left a comment

One issue, otherwise cool 👍

[NG] fix input reset on datepicker
When using clrDate, setting input to null would not
clear the input.

closes #3012

Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan force-pushed the coryrylan:topic/datepicker-value-bug branch from daed595 to e51466d Jan 22, 2019

@coryrylan coryrylan merged commit 1d115f8 into vmware:master Jan 22, 2019

1 of 2 checks passed

deploy/netlify Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Jinnie Jinnie added this to the 1.0.5 milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment