Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] fix DataGrid clearSelection for SingleSelect mode #3117

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@sergiupantiru
Copy link
Contributor

sergiupantiru commented Feb 15, 2019

Selection was not cleared when Filters were applied for SingleSelect mode

closes #3106

Signed-off-by: Sergiu Pantiru 12131904+sergiupantiru@users.noreply.github.com

[NG] fix DataGrid clearSelection for SingleSelect mode
Selection was not cleared when Filters were applied for SingleSelect mode

closes #3106

Signed-off-by: Sergiu Pantiru <12131904+sergiupantiru@users.noreply.github.com>
@youdz

youdz approved these changes Feb 15, 2019

Copy link
Contributor

youdz left a comment

Wow, you even added some unit tests we were missing for single selection, even though some of them weren't impacted by your fix.

This is awesome, you win 100 internet points. 🏆

@sergiupantiru

This comment has been minimized.

Copy link
Contributor Author

sergiupantiru commented Feb 15, 2019

Ha, thanks. It's good to have some points in the beginning, this way I can loose a few along the way 😄

@youdz youdz added Bug Dev labels Feb 15, 2019

@gnomeontherun gnomeontherun added this to the 1.1.1 milestone Feb 27, 2019

@gnomeontherun gnomeontherun merged commit 871743d into vmware:master Feb 27, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.