Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] fix a11y issue password input (#3135) #3148

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@coryrylan
Copy link
Contributor

coryrylan commented Feb 28, 2019

  • [NG] fix a11y issue password input

Make show/hide icon button/focusable

closes #3122

Signed-off-by: Cory Rylan crylan@vmware.com

[NG] fix a11y issue password input (#3135)
* [NG] fix a11y issue password input

Make show/hide icon button/focusable

closes #3122

Signed-off-by: Cory Rylan <crylan@vmware.com>
@vmwclabot

This comment has been minimized.

Copy link
Member

vmwclabot commented Feb 28, 2019

@coryrylan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@youdz

youdz approved these changes Feb 28, 2019

@coryrylan coryrylan changed the title [NG] fix a11y issue password input (#3135) (v1 branch merge) [NG] fix a11y issue password input (#3135) Mar 1, 2019

@coryrylan coryrylan changed the title (v1 branch merge) [NG] fix a11y issue password input (#3135) [NG] fix a11y issue password input (#3135) Mar 1, 2019

@Jinnie

Jinnie approved these changes Mar 1, 2019

@coryrylan coryrylan merged commit 9f2e19a into vmware:v1 Mar 1, 2019

1 of 2 checks passed

deploy/netlify Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@coryrylan coryrylan added this to the 2.0 milestone Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.