Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] fix input group styles/tests #3158

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@coryrylan
Copy link
Contributor

coryrylan commented Mar 3, 2019

Fixes style alignment issue with input group. Also fixes broken unit test for datepicker testing wrong datepicker template. Screenshot updates are minor alignment updates with input groups.

closes #3084 closes #3083

Signed-off-by: Cory Rylan crylan@vmware.com

Release Notes:
Fix multiple CSS issues related to alignment inconsistency with input group icons.

@coryrylan coryrylan self-assigned this Mar 3, 2019

@coryrylan coryrylan force-pushed the coryrylan:topic/password-css-fix branch from 96afe14 to 929accc Mar 3, 2019

[NG] fix input group styles/tests
closes #3084 closes #3083

Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan force-pushed the coryrylan:topic/password-css-fix branch from 929accc to f2916bc Mar 3, 2019

@gnomeontherun gnomeontherun self-requested a review Mar 4, 2019

@Shijir

Shijir approved these changes Mar 5, 2019

@@ -93,6 +93,7 @@
& > .clr-input-group {
max-width: 100%;
width: 100%;
padding-right: 0.4rem;

This comment has been minimized.

@Shijir

Shijir Mar 5, 2019

Contributor

Does 0.4rem align with our baseline? As it seems to be very specific, do we need to assign this to a variable?

@coryrylan coryrylan merged commit 2717e5d into vmware:master Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.