Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[NG] Fix pagination init lifecycle #3175
Because of a lifecycle quirk, we would instantiate as many ClrDatagridRow components
referenced this pull request
Mar 5, 2019
hippee-lee left a comment
Just the one question about the new public property in Page.
I do have a general comment about overloaded selectors. I have mixed feelings about them. When I read the integration test I had to read it twice before I realized how it was working b/c I scanned past the selector right to the class. I know we use the pattern in several different place but it always makes me stop and think b/c I haven't memorized which ones are overloaded.
@hippee-lee: You're right, in this case the selector overload is pointless, my bad. I'm switching to an attribute directive since I control the test component anyway.
For our components though, we sadly don't have much choice since Angular doesn't offer a good composition pattern yet. But I understand the concern, maybe we should think of a way to document overloads somewhere in the code.