Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NG] remove duplicate aria behavior with alerts #3196

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@coryrylan
Copy link
Contributor

coryrylan commented Mar 8, 2019

Removed unnecessary aria-live attribute when using role="alert".

closes #3195

Release Notes:
Improved accessibility for alert component.

Signed-off-by: Cory Rylan crylan@vmware.com

[NG] remove duplicate aria behavior with alerts
closes #3195

Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan self-assigned this Mar 8, 2019

@Jinnie

Jinnie approved these changes Mar 8, 2019

@youdz

youdz approved these changes Mar 8, 2019

@coryrylan coryrylan merged commit f0978f3 into vmware:master Mar 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@coryrylan coryrylan added this to the 1.1.2 milestone Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.