Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] fix node height inconsistency #3241

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@coryrylan
Copy link
Contributor

commented Mar 25, 2019

Fixes node height inconsistency as described in #3142
Node elements should be 32px in height as described in spec #239

Release Notes:
Fix for height inconsistencies with tree view.

closes #3142

Signed-off-by: Cory Rylan crylan@vmware.com

[UI] fix node height inconsistency
closes #3142

Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan self-assigned this Mar 25, 2019

@Shijir

Shijir approved these changes Mar 25, 2019

pr fixup
Signed-off-by: Cory Rylan <crylan@vmware.com>

@coryrylan coryrylan merged commit 6cc84a4 into vmware:master Mar 28, 2019

3 of 6 checks passed

Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

hippee-lee added a commit that referenced this pull request Apr 22, 2019

[UI] fix node height inconsistency (#3241)
* [UI] fix node height inconsistency

closes #3142

Signed-off-by: Cory Rylan <crylan@vmware.com>

hippee-lee added a commit to hippee-lee/clarity that referenced this pull request Apr 25, 2019

fix: Updates gemini reference images for the tree node height patch (v…
…mware#3241)

Signed-off-by: Matt Hippely <mhippely@vmware.com>

hippee-lee added a commit that referenced this pull request Apr 25, 2019

fix: Updates gemini reference images for the tree node height patch (#…
…3241) (#3322)

Signed-off-by: Matt Hippely <mhippely@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.