ddlog.h: Functions to pass non-C strings to DDlog. #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddlog.h
can be used when invoking ddlog from other programminglanguages. Such languages - such as Go - may not be able to easily /
cheaply generate a null-terminated string from their own string type.
For example Go provides
_GoStringPtr
(https://golang.org/cmd/cgo/)which gives access to the underlying byte array (should be treated as
immutable), but that array may not be null-terminated. Which means that
in order to call
ddlog_string
, one has to make a copy of the stringfirst (e.g. with
CString
) and ensure it is null terminated. Given thatddlog makes its own copy of the string when building the record, we are
up to 2 copies.
This commit adds three functions that accept non-null-terminated
strings:
In addition,
ddlog_get_str_with_length()
was modified to return string lengthalong with pointer, which may be more convenient than calling
ddlog_get_strlen()
in some cases.Resolves #515.