Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Wrong network type in config.json #1225

Closed
oliverbestmann opened this issue May 8, 2017 · 2 comments · Fixed by #1229
Closed

Wrong network type in config.json #1225

oliverbestmann opened this issue May 8, 2017 · 2 comments · Fixed by #1229
Assignees
Labels

Comments

@oliverbestmann
Copy link

When starting the docker-engine with this plugin, docker creates a bind mount for /etc/hosts and /etc/resolv.conf. To me, it looks like this is happening because of this line in the config file: https://github.com/vmware/docker-volume-vsphere/blob/master/plugin/config.json#L39

I think the correct value should be the empty string. Compare with this: https://github.com/moby/moby/blob/bbce24997c7a31454edd1d3d979823582bcdd95d/plugin/v2/plugin_linux.go#L42

@msterin
Copy link
Contributor

msterin commented May 8, 2017

Yep, thanks for the catch. //CC @shuklanirdesh82

@shuklanirdesh82
Copy link
Contributor

Thanks @oliverbestmann for sharing details!

#1225 (comment)
I think the correct value should be the empty string. Compare with this: https://github.com/moby/moby/blob/bbce24997c7a31454edd1d3d979823582bcdd95d/plugin/v2/plugin_linux.go#L42

I will test out locally and supply a quick fix, confirmed this change with @msterin offline (Thanks to Mark!)

/CC @msterin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants