Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

vShared plugin: userguide [SKIP CI] #1793

Merged
merged 5 commits into from Aug 23, 2017

Conversation

luomiao
Copy link
Contributor

@luomiao luomiao commented Aug 22, 2017

Userguide for vShared plugin

Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you settled on name? Is it vshared? VMDK block volumes are shared too (albeit with a limitation)! How about vFile?

@luomiao
Copy link
Contributor Author

luomiao commented Aug 22, 2017

@pdhamdhere
No the name is not finally settled down yet!
vShared is kind of short for vsphere shared volume. But this comes with the conflicts you have mentioned.
vFile sounds good to me but will wait for others' opinions about the naming :)

Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Only have some comments/questions.

Detailed documentation can be found on our [GitHub Documentation Page](http://vmware.github.io/docker-volume-vsphere/documentation/).

## Prerequisites
* Docker version 1.30/17.06.0 is required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 1.30? Docker engine API version?


## Prerequisites
* Docker version 1.30/17.06.0 is required.
* To use vShared plugin, hosts must be Docker Swarm mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hosts must be Docker Swarm mode." -> "hosts must be running in Swarm mode."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

#### Creating a persistent volume from vShared plugin
```
$ docker volume create --driver=vshared --name=SharedVol -o size=10gb
$ docker volume ls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to show the output of the command here?

$ docker volume inspect SharedVol
```
Options for creation will be the same for the base volume plugin.
Please refer to the base volume plugin for proper options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the options in base volume plugin are supported, for example "fstype" is not supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Also, Please refer to the base volume plugin for more options.

* Docker version 1.30/17.06.0 is required.
* To use vShared plugin, hosts must be Docker Swarm mode.
[How to create a swarm](https://docs.docker.com/engine/swarm/swarm-tutorial/create-swarm/)
[How to add nodes to the swarm](https://docs.docker.com/engine/swarm/swarm-tutorial/add-nodes/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a line break here? And also before the previous link.


#### Creating a persistent volume from vShared plugin
```
$ docker volume create --driver=vshared --name=SharedVol -o size=10gb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace all vshared with vFile

# ssh to node1
$ docker run --rm -it -v SharedVol:/mnt/myvol --name busybox-on-node1 busybox
/ # cd /mnt/myvol
# write data into mounted shared volume
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to read/write data. This might give an impression that we can either read or write from one container. Same for line 53.

$ docker volume rm SharedVol
```

## Installing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Installing be above usage examples?

Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shivanshu21 shivanshu21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luomiao luomiao merged commit 14c95a1 into vmware-archive:master Aug 23, 2017
@luomiao
Copy link
Contributor Author

luomiao commented Aug 23, 2017

resolves #1796

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants