Skip to content

Commit

Permalink
Fix the vulnerability issues in the job service code
Browse files Browse the repository at this point in the history
'Errors unhandled' in 'jobservice/job/impl/logger/job_logger.go'
'TLS InsecureSkipVerify set true' in 'jobservice/opm/hook_client.go'
  • Loading branch information
steven-zou committed Apr 12, 2018
1 parent 75e6b5d commit b5b728b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion src/jobservice/job/impl/logger/job_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func New(logPath string, level string) *JobLogger {
//Implements logger.Closer interface
func (jl *JobLogger) Close() error {
if jl.streamRef != nil {
jl.streamRef.Close()
return jl.streamRef.Close()
}

return nil
Expand Down
4 changes: 0 additions & 4 deletions src/jobservice/opm/hook_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package opm

import (
"crypto/tls"
"encoding/json"
"errors"
"fmt"
Expand Down Expand Up @@ -38,9 +37,6 @@ func NewHookClient() *HookClient {
Transport: &http.Transport{
MaxIdleConns: maxIdleConnections,
IdleConnTimeout: idleConnectionTimeout,
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
},
},
}

Expand Down

0 comments on commit b5b728b

Please sign in to comment.