New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable vrli log configuration in vra #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three cmdlets for managing the basic configuration of vRealize Automation's integration with vRealize Log Insight. - `Get-vRAvRLIConfig` - `Set-vRAvRLIConfig` - `Remove-vRAvRLIConfig` #47 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
GaryJBlake
reviewed
Sep 14, 2022
Addresses the review comments. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
GaryJBlake
reviewed
Sep 14, 2022
Bump lines close to col 120 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
|
LGTM - Thanks for addressing the comments |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Adds three cmdlets for managing the basic configuration of vRealize Automation's integration with vRealize Log Insight.
Get-vRAvRLIConfigSet-vRAvRLIConfigRemove-vRAvRLIConfigSigned-off-by: Ryan Johnson johnsonryan@vmware.com
Type of Pull Request
Please describe:
Related to Existing Issues
Issue Number: Closes #47
Test and Documentation Coverage
Breaking Changes?