Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken link to minimal setup script #265

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@prashant-shahi
Copy link
Contributor

commented Sep 11, 2019

What this PR does / why we need it:
Fixing the broken link in README file.

Which issue(s) this PR fixes :
Fixes #264

@vmwclabot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@prashant-shahi, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@kreddyj
Copy link
Contributor

left a comment

Thanks for pointing the error and PR.

@prashant-shahi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

It took me a while searching in the repo code to figure out the default credentials.

It would be nice to display the default credentials it in the README file itself.

@kreddyj

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

It took me a while searching in the repo code to figure out the default credentials.

It would be nice to display the default credentials it in the README file itself.

Thanks for pointing out that too. We disabled the login feature with #251 PR and updated the docker image in the main setup YAMLs. We need to update the docker images in minimal support too.

Please sign vmware CLA for us to merge this PR.

@kreddyj

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@prashant-shahi we updated the version in minimal setup files too, please use the latest ones. Thanks.

@vmwclabot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@prashant-shahi, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

@prashant-shahi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@kreddyj Done with signing the CLA.

@kreddyj kreddyj merged commit a2e3ac9 into vmware:master Sep 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
vmwclabot CLA signed and approved, merge can proceed
Details
@vmwclabot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@prashant-shahi, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.