New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM creation. #123

Closed
hartsock opened this Issue Aug 20, 2014 · 8 comments

Comments

Projects
None yet
2 participants
@hartsock
Member

hartsock commented Aug 20, 2014

part of: issues/122

Create tooling to support automated creation of an RPM package for pyVmomi.

@michaelrice

This comment has been minimized.

Show comment
Hide comment
@michaelrice

michaelrice Aug 22, 2014

Contributor

Ive created this project to submit to the Fedora team for review. I have built it in mock and verified that both the python2 and python3 packages work and connect to vcenter on Fedora 20. There are a couple of issues reported by rpmlint but Ill address those based on how the package review goes.

Ill update this with the bugzilla tracking number once I get the review request opened.

Contributor

michaelrice commented Aug 22, 2014

Ive created this project to submit to the Fedora team for review. I have built it in mock and verified that both the python2 and python3 packages work and connect to vcenter on Fedora 20. There are a couple of issues reported by rpmlint but Ill address those based on how the package review goes.

Ill update this with the bugzilla tracking number once I get the review request opened.

@michaelrice

This comment has been minimized.

Show comment
Hide comment
@michaelrice

michaelrice Aug 22, 2014

Contributor

Here is the link to the bugzilla package review: https://bugzilla.redhat.com/show_bug.cgi?id=1132971

Contributor

michaelrice commented Aug 22, 2014

Here is the link to the bugzilla package review: https://bugzilla.redhat.com/show_bug.cgi?id=1132971

@hartsock

This comment has been minimized.

Show comment
Hide comment
@hartsock

hartsock Aug 22, 2014

Member

@michaelrice can we get the tool you're using to copy License.txt into a top level file per RPM package standards? I think it's supposed to be renamed COPYING as a top level file.

Member

hartsock commented Aug 22, 2014

@michaelrice can we get the tool you're using to copy License.txt into a top level file per RPM package standards? I think it's supposed to be renamed COPYING as a top level file.

@hartsock

This comment has been minimized.

Show comment
Hide comment
@hartsock

hartsock Aug 22, 2014

Member

@michaelrice - I opened a PR to begin tweaking the requirements to fit inside Fedora's requirements. For example we need to use PyYAML <= 3.10

Member

hartsock commented Aug 22, 2014

@michaelrice - I opened a PR to begin tweaking the requirements to fit inside Fedora's requirements. For example we need to use PyYAML <= 3.10

@hartsock

This comment has been minimized.

Show comment
Hide comment
@hartsock

hartsock Aug 22, 2014

Member

NOTE see RedHat bug 1132971 for details on more work to do.

Member

hartsock commented Aug 22, 2014

NOTE see RedHat bug 1132971 for details on more work to do.

@michaelrice

This comment has been minimized.

Show comment
Hide comment
@michaelrice

michaelrice Aug 23, 2014

Contributor

Based on the review one of the requests was to run the test during the package process. There is currently no vcrpy and no contextdecorator package in Fedora. They said not running the tests is not a blocker. I have no problems creating packages for vcrpy and contextdecorator its just going to slow the process of getting the rpm accepted since I would have to get the other two packages accepted first. Im thinking we should proceed with out tests at this point then I can add them later once I get those other dependencies packaged and accepted.

@hartsock What are your thoughts?

Contributor

michaelrice commented Aug 23, 2014

Based on the review one of the requests was to run the test during the package process. There is currently no vcrpy and no contextdecorator package in Fedora. They said not running the tests is not a blocker. I have no problems creating packages for vcrpy and contextdecorator its just going to slow the process of getting the rpm accepted since I would have to get the other two packages accepted first. Im thinking we should proceed with out tests at this point then I can add them later once I get those other dependencies packaged and accepted.

@hartsock What are your thoughts?

@hartsock

This comment has been minimized.

Show comment
Hide comment
@hartsock

hartsock Aug 25, 2014

Member

@michaelrice Our priority is to clear the blockers and get 2014.1.1 into Fedora.

That said,

It would be really nice to have all the necessary support packages in place on Fedora to support testing since vcrpy is used for recording network traffic and I would like to begin evangelizing test and bug report techniques that involve turning on a decorator for recording and logging network traffic to a cassette file. I hope the fixture recording technique can become a standard troubleshooting tool.

If we have spare cycles I would like to promote both vcrpy and contextdecorator into Fedora since it will improve the state of affairs for the distro + python. But I don't want to delay our work for that.

Member

hartsock commented Aug 25, 2014

@michaelrice Our priority is to clear the blockers and get 2014.1.1 into Fedora.

That said,

It would be really nice to have all the necessary support packages in place on Fedora to support testing since vcrpy is used for recording network traffic and I would like to begin evangelizing test and bug report techniques that involve turning on a decorator for recording and logging network traffic to a cassette file. I hope the fixture recording technique can become a standard troubleshooting tool.

If we have spare cycles I would like to promote both vcrpy and contextdecorator into Fedora since it will improve the state of affairs for the distro + python. But I don't want to delay our work for that.

hartsock added a commit to hartsock/pyvmomi that referenced this issue Aug 25, 2014

Fix Open Source License File
Our License.txt file cannot be found by RedHat tooling.

related to vmware#133
related to vmware#123

hartsock added a commit to hartsock/pyvmomi that referenced this issue Aug 25, 2014

Fix Open Source License File
Our License.txt file cannot be found by RedHat tooling.

related to vmware#133
related to vmware#123
@hartsock

This comment has been minimized.

Show comment
Hide comment
@hartsock

hartsock Aug 26, 2014

Member

NOTE: The license file is not making it into the tarball. I would be wiling to move or change things so that whatever tool you are using will make sure to include that.

Member

hartsock commented Aug 26, 2014

NOTE: The license file is not making it into the tarball. I would be wiling to move or change things so that whatever tool you are using will make sure to include that.

hartsock added a commit to hartsock/pyvmomi that referenced this issue Aug 26, 2014

Improve sdist and bdist packaging
* Include tests in sdist
* Include license and notices in all distributions
* Update manifest
* Use more conventional file names for licenses, notices, etc.

related to vmware#133
related to vmware#123

closes: vmware#139

hartsock added a commit to hartsock/pyvmomi that referenced this issue Aug 26, 2014

Improve sdist and bdist packaging
* Include tests in sdist
* Include license and notices in all distributions
* Update manifest
* Use more conventional file names for licenses, notices, etc.

related to vmware#133
related to vmware#123

closes: vmware#139

hartsock added a commit to hartsock/pyvmomi that referenced this issue Aug 26, 2014

Improve sdist and bdist packaging
* Include tests in sdist
* Include license and notices in all distributions
* Update manifest
* Use more conventional file names for licenses, notices, etc.

related to vmware#133
related to vmware#123

closes: vmware#139

@hartsock hartsock changed the title from Automated tooling for RPM creation. to RPM creation. Aug 28, 2014

@hartsock hartsock removed this from the pyVmomi 5.5.0-2014.1.1 milestone Aug 28, 2014

@hartsock hartsock closed this Sep 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment