BUG: fix default for post_tfm_kwargs, fixes Inconsistent syllable error #710
Conversation
…or rate between vak eval and predict vocalpy#697
|
Thank you @zhileiz1992, I really appreciate this! I'm dealing with a deadline + something I owe @yardencsGitHub but I will test this early this week so we can get it merged in and release a new version for you |
There was a problem hiding this comment.
This looks like just what we need, thank you @zhileiz1992!
Very minor change:
can you please modify the commit message so that it references the number of the issue you opened?
Like this:
BUG: Fix default for post_tfm_kwargs, fixes #697
That way GitHub will close the issue automatically when we merge this one, and also we'll be able to trace back to the original issue if we need to for some reason.
One way you can do this is in the terminal is like so:
git commit --amend
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Just let me know if I'm not explaining that clearly. Appreciate it!
…://github.com/zhileiz1992/vak into fix-post-tfm-kwargs-default-fixes-vocalpy#697
|
I did the 'git commit --amend' thing, do I still need to git push? |
|
Looks like that fixed it, thanks! Testing now |
|
Tests passed, thank you @zhileiz1992! Much appreciated. I merged in and will release a new bugfix version, then get it on PyPI and conda-forge for you ASAP. |
|
@all-contributors please add @zhileiz1992 for code |
|
I've put up a pull request to add @zhileiz1992! 🎉 |
BUG: fix default for post_tfm_kwargs, fixes Inconsistent syllable error