Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding version check and failing if less than 5.3 #43

Merged
merged 4 commits into from Sep 17, 2013

Conversation

csloisel
Copy link

Feature implementation for #31 and #32.

@prettyboymp
Copy link
Collaborator

@csloisel, this won't work as intended for version less than 5.3 because they will error out before getting to the activation function for invalid syntax because of the use of anonymous functions. You'll need to put need to put the core stuff in a separate file and only have the activation check in the main plugin file.

@ghost ghost assigned prettyboymp Sep 5, 2013
kevinlangleyjr added a commit that referenced this pull request Sep 17, 2013
Adding version check and failing if less than 5.3
@kevinlangleyjr kevinlangleyjr merged commit cfb8027 into master Sep 17, 2013
@kevinlangleyjr kevinlangleyjr deleted the php_version_check_on_activation branch September 17, 2013 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants