Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dropdown flickers when using typehead-url #125

Closed
acirinelli opened this issue Mar 3, 2021 · 6 comments
Closed

Bug: Dropdown flickers when using typehead-url #125

acirinelli opened this issue Mar 3, 2021 · 6 comments

Comments

@acirinelli
Copy link
Contributor

When using a typehead-url request, the search results flicker which is very dizzying for the user. Is there any way we can modify this so that the results are being updated, but not disappearing and reappearing with each query response?

Flicker

@AlexMordred
Copy link
Member

I saw your other PR, would you mind trying to solve this yourself?

@acirinelli
Copy link
Contributor Author

acirinelli commented Mar 23, 2021

Delete this.searchResults = []; in searchTag()
Add this.searchResults = []; in the first line of doSearch()

     doSearch(searchQuery) {
           this.searchResults = [];
          ...

Since I already pushed my other displayField pull request into my fork master branch since I am using it, I cannot fork the repo again. So the code is propagating into my new branches to make this change. I would have to delete the other pull request 130 and then basically start over with two new clean ones. LMK...

@AlexMordred
Copy link
Member

AlexMordred commented Mar 24, 2021

I checked the new commit, looks fine, thanks. I can merge everything as one piece as long as you fix the original PR.

@acirinelli
Copy link
Contributor Author

ok I fixed the original pull request. Also set the default value of displayField to null as discussed since it is optional. Updated the readme file to incorporate this change.

@AlexMordred
Copy link
Member

Thanks. Had to return this.searchResults = []; to searchTag() with an extra condition because the typeahead wasn't disappearing after you erase the last character in the input field in non-ajax mode. This shouldn't break your fix. WIll release everything soon.

@AlexMordred
Copy link
Member

Released with v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants