Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/print: split up information more logically #64

Merged
merged 1 commit into from
Feb 9, 2019

Conversation

CameronNemo
Copy link
Contributor

@CameronNemo CameronNemo commented Feb 8, 2019

Should address #41 and #57

Copy link
Contributor

@bobertlo bobertlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this is exactly what I meant with the CUPS issue and this is a great improvement!

I just have some small tweaks for the system-config-printer/PolicyKit section. I really think it would be cleaner to have information on how to just run the program before getting into the topic of PolicyKit privileges.

launcher, or via the command line:

```
$ system-config-printer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be # system-config-printer. I'd like this a lot better if it was shown as running with root, followed by a note about the need to run as root, and the polkit exceptions and a mention of the cups-pk-helper package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I waffled a bit on whether to use root or user in the example. Went with user because it is typically bad form to run GUI apps as root. I will change it though. It is just an example, and as you mention below the audience will have some level of basic proficiency.


If you are not using the `polkit` helper mentioned above, the command must be
invoked as root. Various packages can be used invoke GUI applications as root,
including `lxqt-sudo` and `kdesu`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is slightly outside of the scope of this page. This handbook has so far been assuming basic proficiency of being able to launch both user and superuser commands from a terminal, and we might be better off sticking to that assumption here.

`cups-pk-helper` is installed.
Normally this tool would require root privileges to configure printers, but
unprivileged access through `polkit` can be achieved with a helper. If you are
interested in this, install the helper:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are using PolicyKit, you can install the cups-pk-helper package to allow unprevileged users access to CUPS configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well one note I would have here is that the CLI tools and web interface would still need root. Just system-config-printer and some other GUI tools take advantage of the policykit helpers.

Copy link
Contributor

@bobertlo bobertlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobertlo bobertlo merged commit 490a86f into void-linux:master Feb 9, 2019
@bobertlo bobertlo mentioned this pull request Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants