Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs: add vaapi dependencies. #12414

Closed
wants to merge 1 commit into from

Conversation

@Valeyard1
Copy link
Contributor

commented Jun 12, 2019

closes #10762

closes #10762
@Hoshpak

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

This seems wrong to me. Hardware-specific drivers should not be in the dependencies of a package unless the package cannot be executed without them. In this case they enable additional functionality so it should be up to the user to install the apropriate driver for his hardware.

@xtraeme

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

I suspect the code uses dlopen().

@xtraeme

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

I agree with @Hoshpak

It's weird that you added them via makedepends but were not added to depends.

xbps-src can't detect dlopen()ed dependencies, remember.

@Hoshpak

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

I think the maximum that would be apropriate here would be an install message that advises the users that the drivers can optionally be installed if the feature is needed. I just tried on a system that already had the drivers installed and it worked fine so they are not needed at compile time. I'm closing this PR, feel free to create a new one if you want to add an install message.

@Hoshpak Hoshpak closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.