-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carla: update to 2.3.0 #23390
Carla: update to 2.3.0 #23390
Conversation
carla-control command does not work:
liblo-devel is inserted in the template. What is the problem? |
Package this: https://github.com/dsacre/pyliblo and make it a dependency. |
The template looks mostly ok for pyliblo, but you should put that commit in this PR. Everything that is needed for one package to be built should all be in the same PR. |
Many thanks for your patience @fosslinux |
I updated Carla to 2.2.0, which has the qt5 patch included, and fixed xlint for pyliblo. I have 2 questions:
EDIT: patch had missing whitespaces |
On Travis we run the git version of xlint. |
I cleaned the commits and removed JUCE used for VST3 plugins to support
make[1]: Entering directory '/builddir/Carla-2.2.0/source/frontend'
/usr/bin/pyrcc5 ../../resources/resources.qrc -o resources_rc.py
/usr/bin/pyrcc5: line 2: /usr/bin/python3: No such file or directory
make[1]: *** [Makefile:105: resources_rc.py] Error 127
make[1]: Leaving directory '/builddir/Carla-2.2.0/source/frontend'
make: *** [Makefile:175: frontend] Error 2
=> libedit-20191231.3.1_1: building [gnu-configure] (dependency of pcre) for x86_64...
[target] ncurses-devel-6.2_3: found (/host/binpkgs)
[runtime] ncurses-devel-6.2_3: found (/host/binpkgs)
[runtime] libedit-20191231.3.1_1: not found (self, ignored)
=> libedit-20191231.3.1_1: installing target dependencies: ncurses-devel-6.2_3 ...
=> libedit-20191231.3.1_1: removing autodeps, please wait...
=> ERROR: libedit-20191231.3.1_1: failed to install 'ncurses-devel-6.2_3' dependency! (error 19)
ncurses-libs-6.2_3 in transaction breaks installed pkg `ncurses-6.2_2' I do not know how to fix it, I leave it to someone interested. |
The arm problem would have been a transient issue The aarch64 issue can be resolved by putting python3 in hostmakdependes |
@jkoderu-git ping? |
@fosslinux Thank you, I added it now. @ericonr I resolved the requested changes. |
Hi, I think you closed this accidentally? |
Hi, yes. I had problems with my local git repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the Carla commits into a single one.
0fa9fc0
to
5bc891d
Compare
f0f6faf
to
ed6a7a1
Compare
1dd4908
to
0b80fd7
Compare
Why are you skipping CI? |
It already compiled to all machines. I skipped it because I only changed the comment you said, to save CI time. |
Hey, please rebase your branch on top of master, as of it's now, your PR is lagging behind too much, the lint steps has problems if it's lagged behind more than 200 changes |
Carla: add pyliblo dependency Carla: fix musl build [skip ci]
Thank you! |
2.3.1 is out, could you rebase again on top of master? |
pkgname=pyliblo | ||
version=0.10.0 | ||
revision=1 | ||
wrksrc="pyliblo-${version}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default value of $wrksrc, so it can be dropped
Supersed by #33809, thanks! |
@nutcase84