Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carla: update to 2.3.0 #23390

Closed
wants to merge 2 commits into from
Closed

Conversation

jkoderu-git
Copy link
Contributor

@jkoderu-git jkoderu-git commented Jul 4, 2020

@nutcase84

@jkoderu-git
Copy link
Contributor Author

carla-control command does not work:

Traceback (most recent call last):
File "/usr/share/carla/carla-control", line 22, in <module>
from carla_control import *
File "/usr/share/carla/carla_control.py", line 34, in <module>
from liblo import (
ModuleNotFoundError: No module named 'liblo'

liblo-devel is inserted in the template. What is the problem?

@fosslinux
Copy link
Contributor

Package this: https://github.com/dsacre/pyliblo and make it a dependency.

@fosslinux
Copy link
Contributor

The template looks mostly ok for pyliblo, but you should put that commit in this PR. Everything that is needed for one package to be built should all be in the same PR.

@jkoderu-git
Copy link
Contributor Author

Many thanks for your patience @fosslinux

@jkoderu-git jkoderu-git changed the title Carla: update to 2.1.1 Carla: update to 2.2.0 Oct 15, 2020
@jkoderu-git
Copy link
Contributor Author

jkoderu-git commented Oct 15, 2020

I updated Carla to 2.2.0, which has the qt5 patch included, and fixed xlint for pyliblo. I have 2 questions:

  • local xlint does not complain of deprecated noarch and Travis does
  • the new patch for libmagic fails to apply

EDIT: patch had missing whitespaces

@ericonr
Copy link
Member

ericonr commented Oct 15, 2020

On Travis we run the git version of xlint.

@jkoderu-git
Copy link
Contributor Author

jkoderu-git commented Oct 16, 2020

I cleaned the commits and removed JUCE used for VST3 plugins to support x86_64-musl.

aarch64* fails with:

make[1]: Entering directory '/builddir/Carla-2.2.0/source/frontend'
/usr/bin/pyrcc5 ../../resources/resources.qrc -o resources_rc.py
/usr/bin/pyrcc5: line 2: /usr/bin/python3: No such file or directory
make[1]: *** [Makefile:105: resources_rc.py] Error 127
make[1]: Leaving directory '/builddir/Carla-2.2.0/source/frontend'
make: *** [Makefile:175: frontend] Error 2

armv7l* has a dependency problem:

=> libedit-20191231.3.1_1: building [gnu-configure] (dependency of pcre) for x86_64...
   [target] ncurses-devel-6.2_3: found (/host/binpkgs)
   [runtime] ncurses-devel-6.2_3: found (/host/binpkgs)
   [runtime] libedit-20191231.3.1_1: not found (self, ignored)
=> libedit-20191231.3.1_1: installing target dependencies: ncurses-devel-6.2_3 ...
=> libedit-20191231.3.1_1: removing autodeps, please wait...
=> ERROR: libedit-20191231.3.1_1: failed to install 'ncurses-devel-6.2_3' dependency! (error 19)
ncurses-libs-6.2_3 in transaction breaks installed pkg `ncurses-6.2_2'

I do not know how to fix it, I leave it to someone interested.

@fosslinux
Copy link
Contributor

The arm problem would have been a transient issue The aarch64 issue can be resolved by putting python3 in hostmakdependes

@ericonr
Copy link
Member

ericonr commented Feb 18, 2021

@jkoderu-git ping?

srcpkgs/Carla/template Outdated Show resolved Hide resolved
srcpkgs/Carla/template Outdated Show resolved Hide resolved
@jkoderu-git
Copy link
Contributor Author

jkoderu-git commented Apr 30, 2021

@fosslinux Thank you, I added it now.

@ericonr I resolved the requested changes.

@ericonr
Copy link
Member

ericonr commented Apr 30, 2021

Hi, I think you closed this accidentally?

@jkoderu-git jkoderu-git changed the title Carla: update to 2.2.0 Carla: update to 2.3.0 Apr 30, 2021
@jkoderu-git jkoderu-git reopened this Apr 30, 2021
@jkoderu-git
Copy link
Contributor Author

Hi, I think you closed this accidentally?

Hi, yes. I had problems with my local git repository.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the Carla commits into a single one.

srcpkgs/pyliblo/template Outdated Show resolved Hide resolved
srcpkgs/Carla/template Outdated Show resolved Hide resolved
@jkoderu-git jkoderu-git force-pushed the patch-1 branch 2 times, most recently from 0fa9fc0 to 5bc891d Compare May 7, 2021 18:44
@jkoderu-git jkoderu-git force-pushed the patch-1 branch 2 times, most recently from f0f6faf to ed6a7a1 Compare May 21, 2021 16:41
srcpkgs/Carla/template Outdated Show resolved Hide resolved
@jkoderu-git jkoderu-git force-pushed the patch-1 branch 2 times, most recently from 1dd4908 to 0b80fd7 Compare May 21, 2021 17:24
@paper42
Copy link
Member

paper42 commented May 21, 2021

Why are you skipping CI?

@jkoderu-git
Copy link
Contributor Author

jkoderu-git commented May 21, 2021

It already compiled to all machines. I skipped it because I only changed the comment you said, to save CI time.

@sgn
Copy link
Member

sgn commented May 21, 2021

Hey, please rebase your branch on top of master, as of it's now, your PR is lagging behind too much, the lint steps has problems if it's lagged behind more than 200 changes

Carla: add pyliblo dependency

Carla: fix musl build

[skip ci]
@jkoderu-git
Copy link
Contributor Author

Hey, please rebase your branch on top of master, as of it's now, your PR is lagging behind too much, the lint steps has problems if it's lagged behind more than 200 changes

Thank you!

@paper42
Copy link
Member

paper42 commented Aug 7, 2021

2.3.1 is out, could you rebase again on top of master?

pkgname=pyliblo
version=0.10.0
revision=1
wrksrc="pyliblo-${version}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default value of $wrksrc, so it can be dropped

@ericonr
Copy link
Member

ericonr commented Dec 7, 2021

Supersed by #33809, thanks!

@ericonr ericonr closed this Dec 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants