Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-files: modify kernel listing in vkpurge #24310

Closed
wants to merge 2 commits into from
Closed

base-files: modify kernel listing in vkpurge #24310

wants to merge 2 commits into from

Conversation

Ypnose
Copy link
Contributor

@Ypnose Ypnose commented Aug 16, 2020

By default, kernel listing is not done by version. For example :

4.19.131_1
5.4.18_1
5.4.50_1
5.4.5_1
5.4.9_1
5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :

4.19.131_1
5.4.5_1
5.4.9_1
5.4.11_1
5.4.18_1
5.4.50_1

By default, kernel listing is not done by version, For example :

4.19.131_1
5.4.18_1
5.4.50_1
5.4.5_1
5.4.9_1
5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :
4.19.131_1
5.4.5_1
5.4.9_1
5.4.11_1
5.4.18_1
5.4.50_1
@ahesford
Copy link
Member

Please rebase, base-files has already been revbumped.

@Ypnose
Copy link
Contributor Author

Ypnose commented Aug 21, 2020

I did that pull request using web interface. You can directly rebase when you accept the pull request :
https://github.blog/2016-09-26-rebase-and-merge-pull-requests/

@sgn sgn closed this in 7bffaa5 Aug 21, 2020
@q66
Copy link
Contributor

q66 commented Aug 21, 2020

version sort is not standard in POSIX, so this might break depending on which implementation of sort people are using

@sgn
Copy link
Member

sgn commented Aug 21, 2020

It seems like I messed up again.

@q66
Copy link
Contributor

q66 commented Aug 21, 2020

it's probably fine, as the common implementations have it (gnu sort, busybox sort, freebsd sort), just pointing out that this is not POSIX

@Ypnose
Copy link
Contributor Author

Ypnose commented Aug 21, 2020

On Void Linux, sort is provided by GNU coreutils. I assume people will use this variant. The idea here is not to support every sort implementation. Even OpenBSD which is known to be restrictive, supports this option. I do not understand how your comment helps us here. If Void Linux needs to stick to POSIX which is totally fine, please provide me a link where it is specified. In that case, this PR can be ignored.

@Ypnose
Copy link
Contributor Author

Ypnose commented Aug 24, 2020

@sgn May I know why this pull request was closed and therefore refused ?

@ahesford
Copy link
Member

The pull request was closed by merging your change (with the revbump).

@sgn
Copy link
Member

sgn commented Aug 24, 2020 via email

@Ypnose
Copy link
Contributor Author

Ypnose commented Aug 30, 2020

My apologies, I didn't notice.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants