poedit: update to 2.4.2 #26434
Merged
poedit: update to 2.4.2 #26434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Nov 21, 2020
| revision=1 | ||
| build_style=gnu-configure | ||
| configure_args="--with-wx-config=wx-config-gtk3" | ||
| hostmakedepends="pkg-config" | ||
| makedepends="boost-devel cld2-devel db-devel enchant2-devel gtk+3-devel | ||
| gtkspell3-devel Lucene++-devel wxWidgets-gtk3-devel" | ||
| gtkspell3-devel libharfbuzz libxml2 Lucene++-devel webkit2gtk |
There was a problem hiding this comment.
I don't understand why these were added; the final package doesn't seem to be linked against them, and they aren't the devel version.
There was a problem hiding this comment.
Re-looking at it, and retesting, may have needed them during build. If they aren't needed, I will open a new PR to remove those
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.