New package: wezterm-20220905_1

[jbenden]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the quality requirements: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64-glibc)

[jbenden]

I've also locally built aarch64 (cross) and i686 (cross).

I do not know what to do about the i686 check errors. These seem like bugs within some Rust crate(s), and may not impact use of the program on i686.

Thoughts, comments, and suggestions are welcomed,
-Joe

[classabbyamp]

you could do something like

if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
    # comment explaining why
    make_check=no
fi

[classabbyamp]

arch's package also installs some shell completions, it would be good to include those too

https://github.com/archlinux/svntogit-community/blob/b903da54ec78dc74fff1e6fb692c358d3898c2fb/trunk/PKGBUILD#L78-L80

[jbenden]

I added zlib-devel in hopes of resolving the various build errors; but it did not help. Additionally, I have no idea on why i686 is segmentation faulting.

Thoughts, suggestions, and/or ideas are always welcomed,
-Joe

[auronandace]

Does the latest version have the same issues?

Also, I came across this page: https://github.com/wez/wezterm/blob/main/README-DISTRO-MAINTAINER.md

[jbenden]

Yup. :(

[wez]

I do not know what to do about the i686 check errors. These seem like bugs within some Rust crate(s), and may not impact use of the program on i686.

Those were serious bugs that would break the program on i686 and should be resolved by wezterm/wezterm@7b904f0

[classabbyamp]

ok i think these are my last comments

[classabbyamp]

I might be able to investigate the cross issue soon, but I think that can be solved later if I don't have time

[classabbyamp]

actually one more thing: swap the location the do_check and do_build functions, so the order matches the order of the steps in xbps-src

[vikigenius]

Is there anything else blocking this from merging? I would love to use Wezterm in void

[classabbyamp]

was going to look at this tonight and see if I can fix cross -- if not, I'll merge it as-is

[paper42]

was going to look at this tonight and see if I can fix cross -- if not, I'll merge it as-is

Great, I also think this might fail to build for ppc*, but I don't have a way to test that and it's just a guess, so I think we can just restrict it when it fails.

[classabbyamp]

ok, last round, hopefully

[jbenden]

@classabbyamp Has anyone told you how awesome you are! Thank you for helping so much with this PR; it has certainly produced a better package!