New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.01_1 #36905

AlaskanEmily · 2022-04-28T22:58:29Z

Testing the changes

I tested the changes in this PR: YES

New package

This new package conforms to the quality requirements: YES

Local build testing

I built this PR locally for my native architecture, (x86_64-glibc)
I built this PR locally for these architectures (if supported. mark crossbuilds):
- x86_64-musl
- i686-glibc

I have marked the parallel toolchain options disabled for musl, as in the last those have had issues and I have not tested that configuration enough to be sure it works properly.

AlaskanEmily · 2022-04-29T08:38:41Z

Ah, I know how to fix the i686 failure, that's what happens when you try to use asm_fast as the base LLDS grade on a platform that doesn't support it.

wangp · 2022-04-30T03:32:05Z

srcpkgs/mercury/template

+		_LLDS_GRADE=none ;;
+esac
+
+_LIBGRADES="hlc.gc,hlc.gc.ssdebug,hlc.gc.memprof,${_LLDS_GRADE}.gc,${_LLDS_GRADE}.gc.stseg,${_LLDS_GRADE}.gc.stseg.decldebug,${_LLDS_GRADE}.gc.stseg.profdeep"


I would remove hlc.gc.ssdebug.

Consider adding hlc.gc.prof and ${_LLDS_GRADE}.gc.debug.stseg.

I suggest listing the grade components in canonical order.

I would remove hlc.gc.ssdebug.

I use ssdebug fairly often, it's extremely useful for debugging issues that only happen in HLC, I would prefer to keep it.

Consider adding hlc.gc.prof and ${_LLDS_GRADE}.gc.debug.stseg.

Isn't decldebug a strict superset of debug?

I suggest listing the grade components in canonical order.

Is there an actual documented canonical order?

Ok, keep ssdebug then.

decldebug is a superset of debug but produces bigger code which is slower to compile. However, a quick check on a project shows that it's only about 6% slower to compile, less than I thought, and the runtime difference is pretty acceptable, too. So it should be fine to skip the .debug grade.

The canonical order is implemented by the canonical_grade script and mmc --output-grade-string.

OK, I reordered the grades based on its output.

srcpkgs/mercury/template

wangp · 2022-04-30T03:42:36Z

srcpkgs/mercury/template

+		vman usr/share/man/man1/mdb.1
+		vman usr/share/man/man1/mprof.1
+		vman usr/share/man/man1/mprof_merge_runs.1
+		vman usr/share/man/man1/mtags.1


mdb is a trivial shell script. I think it should be in the main package.

mtags depends on perl. It's pretty small and more useful than the other tools in this list. Consider moving it to the main package.

AlaskanEmily · 2022-05-15T15:50:53Z

@wangp Is there anything else I need to change before this can be added?

wangp · 2022-05-16T01:05:33Z

It looks okay to me. mtags requires perl at runtime, so you might need a dependency on perl.

classabbyamp · 2022-05-24T23:13:40Z

srcpkgs/mercury/template

+}
+
+mercury-libs_package() {
+	license="custom:LGPL-2.0-only-linking-exception"


this does not affect the metadata on the subpkg, i think (based on this)

srcpkgs/mercury/template

classabbyamp · 2022-05-24T23:15:17Z

srcpkgs/mercury/template

+	vman usr/share/man/man1/mmake.1
+	vman usr/share/man/man1/mmc.1
+	vman usr/share/man/man1/mtags.1
+	vlicense COPYING


should not be needed if this is GPL

If this can't be set on the subpackage, should I set the entire license to be GPL, custom:LGPL-2.0-only-linking-exception then?

For reference, the runtime libraries are LGPL with a static linking exception, and the compiler toolchain itself is GPL.

yeah GPL-2.0-only, custom:LGPL-2.0-only-linking-exception and only install the custom one in the packages

srcpkgs/mercury/template

leahneukirchen · 2022-05-25T15:59:24Z

srcpkgs/mercury/template

+distfiles="http://dl.mercurylang.org/release/mercury-srcdist-${version}.tar.xz"
+checksum=4ab0734aaa66808c91ffe7f54c7d818bdc4f0247aa255932e1e3d50610db4150
+nocross="Mercury cannot be cross-compiled to different architectures"
+noverifyrdeps=yes


what's the rationale for these settings?

leahneukirchen · 2022-05-25T16:01:06Z

Also please rebase for CI.

paper42 · 2022-05-25T18:38:11Z

srcpkgs/mercury/template

+homepage="https://mercurylang.org/"
+distfiles="http://dl.mercurylang.org/release/mercury-srcdist-${version}.tar.xz"
+checksum=4ab0734aaa66808c91ffe7f54c7d818bdc4f0247aa255932e1e3d50610db4150
+nocross="Mercury cannot be cross-compiled to different architectures"


We usually set $nocross to yes or set it to a reason why it can't be cross compiled. This sounds to me like this can't be cross compiled because it can't be cross compiled.

paper42 · 2022-05-25T18:38:53Z

srcpkgs/mercury/template

+maintainer="Emily McDonough <emily@alaskanemily.net>"
+license="GPL-2.0-only"
+homepage="https://mercurylang.org/"
+distfiles="http://dl.mercurylang.org/release/mercury-srcdist-${version}.tar.xz"


classabbyamp · 2022-05-31T00:01:53Z

srcpkgs/mercury/template

+	vmkdir /usr/lib/mercury/lib
+	vmkdir /usr/lib/mercury/conf


I think these should not have a leading slash

classabbyamp · 2022-05-31T00:02:34Z

srcpkgs/mercury/template

+	vcopy usr/lib/mercury/conf/Mercury.config /usr/lib/mercury/conf/Mercury.config
+	vcopy usr/lib/mercury/conf/mercury_conf.h /usr/lib/mercury/conf/mercury_conf.h
+	vcopy usr/lib/mercury/ints /usr/lib/mercury/ints
+	vcopy usr/lib/mercury/inc /usr/lib/mercury/inc
+	vcopy usr/lib/mercury/ints /usr/lib/mercury/ints
+	vcopy usr/lib/mercury/mdb /usr/lib/mercury/mdb
+	vcopy usr/lib/mercury/mmake /usr/lib/mercury/mmake
+	vcopy usr/lib/mercury/lib/libgc*.a /usr/lib/mercury/lib


also should not have leading slashes, i think

srcpkgs/mercury/template

classabbyamp · 2022-05-31T00:31:46Z

srcpkgs/mercury/template

+	noverifyrdeps=yes
+	noshlibprovides=yes
+	pkg_install() {
+		vmkdir /usr/lib/mercury/lib


also no leading slash

classabbyamp · 2022-05-31T00:32:29Z

srcpkgs/mercury/template

+	noshlibprovides=yes
+	pkg_install() {
+		vmkdir /usr/lib/mercury/lib
+		vcopy usr/lib/mercury/lib/libgc*.so /usr/lib/mercury/lib


this should probably be vmove? vcopy means that the file will exist in both mercury and mercury-libs, which would make them conflict.

The mercury-libs version only copies shared libraries, and the mercury version only copies static libraries, so it should work properly I think? If there was a conflict, I would also see this when trying to install or remove the resulting packages, right?

classabbyamp · 2022-05-31T00:32:47Z

srcpkgs/mercury/template

+					vmkdir /usr/lib/mercury/lib/$GRADE
+					vcopy usr/lib/mercury/lib/$GRADE/lib*.so /usr/lib/mercury/lib/$GRADE


same thing here (leading slash and vmove)

Removed leading slash. Is my comment above applicable? Or should this still change to vmove?

srcpkgs/mercury/template

leahneukirchen · 2022-07-19T20:24:39Z

I tried to remove the noverifyrdeps, but it fails not finding libpar_gc.so and I can't actually see it. Any ideas?

AlaskanEmily · 2022-07-23T00:07:33Z

I tried to remove the noverifyrdeps, but it fails not finding libpar_gc.so and I can't actually see it. Any ideas?

It should be copied by the usr/lib/mercury/lib/libgc*.so vcopy.

I had a bunch of issues with the verifyrdeps and verifydeps for libgc and its derivatives, but I didn't think it was important to solve in particular because Mercury has a patched version of libgc which is not compatible with regular Boehm GC (also why it's installed to a "mercury" directory instead of to /usr/lib).

AlaskanEmily · 2022-07-23T00:45:04Z

I tried to remove the noverifyrdeps, but it fails not finding libpar_gc.so and I can't actually see it. Any ideas?

It should be copied by the usr/lib/mercury/lib/libgc*.so vcopy.

I had a bunch of issues with the verifyrdeps and verifydeps for libgc and its derivatives, but I didn't think it was important to solve in particular because Mercury has a patched version of libgc which is not compatible with regular Boehm GC (also why it's installed to a "mercury" directory instead of to /usr/lib).

Having reread this, I see the problem now :)

leahneukirchen · 2022-07-29T12:53:22Z

Ok, let's finish this up. Remove noshlibprovides and shlib_requires from the main package, and noverifyrdeps and noshlibprovides from the subpackages. mercury will depend on mercury-libs which depends on libc so that's fine.

LGTM else.

…01_1

leahneukirchen · 2022-08-02T13:48:01Z

Thanks a lot for holding up with us. :)

paper42 added the new-package This PR adds a new package label Apr 29, 2022

AlaskanEmily force-pushed the master branch from fe88276 to e4723b7 Compare April 30, 2022 01:54

wangp reviewed Apr 30, 2022

View reviewed changes

AlaskanEmily force-pushed the master branch from e4723b7 to f9fc72c Compare May 6, 2022 01:53

classabbyamp reviewed May 24, 2022

View reviewed changes

leahneukirchen reviewed May 25, 2022

View reviewed changes

paper42 reviewed May 25, 2022

View reviewed changes

AlaskanEmily force-pushed the master branch from f9fc72c to 724b83c Compare May 30, 2022 23:36

classabbyamp reviewed May 31, 2022

View reviewed changes

AlaskanEmily force-pushed the master branch 4 times, most recently from da570c8 to 7d6e5b0 Compare July 4, 2022 00:42

AlaskanEmily force-pushed the master branch 2 times, most recently from ad69cd0 to 31d3286 Compare July 23, 2022 03:38

AlaskanEmily force-pushed the master branch 2 times, most recently from ad69cd0 to bf1864a Compare August 2, 2022 03:13

New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.…

4abab50

…01_1

AlaskanEmily force-pushed the master branch from bf1864a to 4abab50 Compare August 2, 2022 03:44

leahneukirchen merged commit 6a2f857 into void-linux:master Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.01_1 #36905

New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.01_1 #36905

AlaskanEmily commented Apr 28, 2022 •

edited

AlaskanEmily commented Apr 29, 2022

wangp Apr 30, 2022

AlaskanEmily Apr 30, 2022 •

edited

wangp Apr 30, 2022

AlaskanEmily May 9, 2022

wangp Apr 30, 2022

AlaskanEmily May 9, 2022

AlaskanEmily commented May 15, 2022

wangp commented May 16, 2022

classabbyamp May 24, 2022

classabbyamp May 24, 2022

AlaskanEmily May 25, 2022

classabbyamp May 25, 2022

AlaskanEmily May 30, 2022

leahneukirchen May 25, 2022

leahneukirchen commented May 25, 2022

paper42 May 25, 2022

paper42 May 25, 2022

AlaskanEmily May 30, 2022

classabbyamp May 31, 2022

classabbyamp May 31, 2022

AlaskanEmily Jul 4, 2022

classabbyamp May 31, 2022

AlaskanEmily Jul 4, 2022

classabbyamp May 31, 2022

AlaskanEmily Jun 11, 2022

classabbyamp May 31, 2022

AlaskanEmily Jul 4, 2022

leahneukirchen commented Jul 19, 2022

AlaskanEmily commented Jul 23, 2022

AlaskanEmily commented Jul 23, 2022 •

edited

leahneukirchen commented Jul 29, 2022

leahneukirchen commented Aug 2, 2022

		vmkdir /usr/lib/mercury/lib/$GRADE
		vcopy usr/lib/mercury/lib/$GRADE/lib*.so /usr/lib/mercury/lib/$GRADE

New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.01_1 #36905

New package: mercury-22.01_1, mercury-libs-22.01_1, mercury-tools-22.01_1 #36905

Conversation

AlaskanEmily commented Apr 28, 2022 • edited

Testing the changes

New package

Local build testing

AlaskanEmily commented Apr 29, 2022

Choose a reason for hiding this comment

AlaskanEmily Apr 30, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlaskanEmily commented May 15, 2022

wangp commented May 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leahneukirchen commented May 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leahneukirchen commented Jul 19, 2022

AlaskanEmily commented Jul 23, 2022

AlaskanEmily commented Jul 23, 2022 • edited

leahneukirchen commented Jul 29, 2022

leahneukirchen commented Aug 2, 2022

AlaskanEmily commented Apr 28, 2022 •

edited

AlaskanEmily Apr 30, 2022 •

edited

AlaskanEmily commented Jul 23, 2022 •

edited