Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngspice: update to 37. #38689

Merged
merged 1 commit into from Sep 23, 2022
Merged

ngspice: update to 37. #38689

merged 1 commit into from Sep 23, 2022

Conversation

mtboehlke
Copy link
Contributor

@mtboehlke mtboehlke commented Aug 15, 2022

Testing the changes

  • I tested the changes in this PR: briefly

I think that the current version of kicad can handle the versioned libngspice object better now. Here is the relevant commit and issue from kicad upstream @ericonr, would you be able to verify?

@classabbyamp classabbyamp added the needs-testing Testing a PR or reproducing an issue needed label Aug 18, 2022
@mtboehlke
Copy link
Contributor Author

mtboehlke commented Aug 23, 2022

I tested a couple of ngspice simulations in kicad using some examples found here, and it does look like it is successfully finding and using libngspice.

@paper42 paper42 removed the needs-testing Testing a PR or reproducing an issue needed label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants