Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan2pdf: corrected a patch to make tesseract available #42968

Merged
merged 1 commit into from Mar 29, 2023

Conversation

numerys
Copy link
Contributor

@numerys numerys commented Mar 24, 2023

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)

@classabbyamp
Copy link
Member

gscan2pdf will also need a revision increment

@numerys numerys force-pushed the gscan2pdf branch 3 times, most recently from 51937f3 to 751c7c1 Compare March 24, 2023 11:50
@classabbyamp
Copy link
Member

squash this into 1 commit and it should be good

Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the changes into one commit. Please also amend the commit message to state more clearly what patch is changed and why.

Optionally you could also mention the issue number in the commit comment (e.g. "closes #42932") to ensure that the corresponding issue is automatically closend when the PR is merged.

@numerys numerys force-pushed the gscan2pdf branch 2 times, most recently from 601e1ea to 751c7c1 Compare March 28, 2023 21:14
numerys added a commit to numerys/void-packages that referenced this pull request Mar 28, 2023
@numerys numerys requested a review from Hoshpak March 28, 2023 21:30
Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat the commit title according to the format lined out in CONTRIBUTING.md :

for template modifications without a version change, use <pkgname>: <reason>

@Hoshpak Hoshpak merged commit da2e07e into void-linux:master Mar 29, 2023
@numerys numerys deleted the gscan2pdf branch March 29, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants