-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] base-files: add kernel hook for /boot freespace #44137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the concept
- Change the threshold size? Make it configurable?
100MB might be a little bit big? In my /boot
each kernel + initramfs + config is ~30MB (zfs and mkinitcpio so that might be different from the usual). maybe 50 or 60 MB?
- Change the threshold to a percentage? I think that's less useful.
agree that it's less useful because it should be the size of 1-2 kernels, IMO
- Change what package this is shipped with? I'm not sure if it applies to all configurations we support/consider.
Only the generic kernels keep old ones around, right? so maybe it could go in linux-base
, which linux{,-lts,-mainline}
all depend on.
- Wording of the message?
lgtm
df0e3d4
to
7d33058
Compare
I based it on dracut default, which looking at my systems have each kernel+initrd pair at about 90M.
That sounds much more appropriate than |
7d33058
to
3fa8a86
Compare
3fa8a86
to
b08318a
Compare
That number is sure to increase in the future, how can we ensure the limit is updated in a timely manner? |
Considering a move to mkinitcpio seems inevitable, the only update for a long while might be a lowering of the value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that approach, should help prevent silly systems breakage
b08318a
to
aff3b5b
Compare
299ca69
to
a1770c5
Compare
The threshold need not be configurable. Just make it 2x (the size of the largest kernel plus the size of the largest initramfs). |
bcd14e6
to
b7f83ad
Compare
Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
b7f83ad
to
33cb87e
Compare
Thoughts: