move the repository stage into the repodata file#575
Closed
Duncaen wants to merge 8 commits into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| for (int i = args; i < argc; i++) { | ||
| r = index_add_pkg(xhp, index, stage, argv[i], force); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| return -ENAMETOOLONG; | ||
| } | ||
|
|
||
| fd = open(path, O_WRONLY|O_CREAT|O_CLOEXEC, 0660); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| printf("index: removed pkg %s\n", pkgver); | ||
| } | ||
| xbps_dictionary_get_cstring_nocopy(obj, "filename-sha256", &sha256); | ||
| if (xbps_file_sha256_check(path, sha256) != 0) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| errno = -r; | ||
| return NULL; | ||
| } | ||
| repo->xhp = xhp; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory
Duncaen
force-pushed
the
stagedata
branch
2 times, most recently
from
May 11, 2025 17:03
729b7ab to
5be8009
Compare
classabbyamp
approved these changes
May 19, 2025
classabbyamp
left a comment
classabbyamp
left a comment
Member
There was a problem hiding this comment.
seems fine overall. is there any function to merge an existing stagedata into a repodata, or is it assumed that the user should unstage before upgrading xbps?
By combining repodata and stage data into a single file its easier to use remote stagedata when enabled. This also avoids having to come up with a new mechanism to fetch -stagedata and having to keep -repodata and -stagedata in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By combining repodata and stage data into a single file its easier to
use remote stagedata when enabled. This also avoids having to come up
with a new mechanism to fetch -stagedata and having to keep -repodata
and -stagedata in sync.