voidspace/juju forked from juju/juju

"space list" follow up

Some tweaks from a review made after the main branch was submitted.

(Review request: http://reviews.vapour.ws/r/2352/)

Implement AllSpaces for "space list" command.

Implements AllSpaces on state, used by the "space list" command.

As part of this state.Space needs a Subnets method that returns all subnets associated with the space. This required changes to both spaces and subnets.

The requirement that all spaces have at least one subnet has been dropped. This will need more work in the CLI/API to complete.

(Review request: http://reviews.vapour.ws/r/2344/)

Added subnets CLI API stub



(Review request: http://reviews.vapour.ws/r/2343/)

Merge + rebase of trunk into net-cli

Couple of test fixes needed. Mostly clean. The only change I did to the tests was change the regexp in this test (in both cmd/juju/subnet/package_test.go and the spaces equivalent) to make [options] an optional string:

```go
// TestHelp runs the command with --help as argument and verifies the
// output.
func (s *BaseSubnetSuite) TestHelp(c *gc.C) {
	stderr, stdout, err := s.RunSuperCommand(c, "--help")
	c.Assert(err, jc.ErrorIsNil)
	c.Check(stdout, gc.Equals, "")
	c.Check(stderr, gc.Not(gc.Equals), "")

	// If s.command is set, use it instead of s.superCmd.
	cmdInfo := s.superCmd.Info()
	var expected string
	if s.command != nil {
		// Subcommands embed EnvCommandBase and have an extra
		// "[options]" prepended before the args.
		cmdInfo = s.command.Info()
		expected = "(?sm).*^usage: juju subnet " +
			regexp.QuoteMeta(cmdInfo.Name) +
			`( \[options\])? ` + regexp.QuoteMeta(cmdInfo.Args) + ".+"
	} else {
		expected = "(?sm).*^usage: juju subnet" +
			`( \[options\])? ` + regexp.QuoteMeta(cmdInfo.Args) + ".+"
	}
	c.Check(cmdInfo, gc.NotNil)
	c.Check(stderr, gc.Matches, expected)

	expected = "(?sm).*^purpose: " + regexp.QuoteMeta(cmdInfo.Purpose) + "$.*"
	c.Check(stderr, gc.Matches, expected)

	expected = "(?sm).*^" + regexp.QuoteMeta(cmdInfo.Doc) + "$.*"
	c.Check(stderr, gc.Matches, expected)
}
```

(Review request: http://reviews.vapour.ws/r/2333/)