Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Disable sending empty ticket / project #10
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Why are you sending pull request with something you think I don't like ? :-D
I can see three ways of doing this:
The third option sounds as the best solution to me, unfortunately, there isn't currently enough flexible form system in angular which would allow us to make it easily... (Misko is working hard on that...)
So I like your decision to do it in $resource, but then, it must be flexible enough...
Your code does not send empty ticket, which is fine, but it allows me to create a project with empty name, that's odd...
$resource service is general purpose service, it knows nothing about tickets neither projects. So we need to add a configuration property, something like "mandatory fields" and then, if any of mandatory field is empty ignore creating...
WRT test, I commented in the commit...