Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pod lib lint #121

Closed
wants to merge 2 commits into from
Closed

Conversation

brockboland
Copy link
Contributor

DO NOT MERGE

I'm just confirming this works. I'll open a new PR with just the relevant commit once it's ready.

@brockboland
Copy link
Contributor Author

My main concern with this was added build time, but the times on this build are actually faster the the build for my last PR. Obviously, this change does't speed things up—it's surely just because Travis was busier last week—but this puts to rest my concern that it would have a huge negative impact on build times.

@vokal-isaac
Copy link
Contributor

pod lib lint added a little over 3 minutes on one of those builds.
—that seems like a worthwhile tradeoff to me.

@brockboland
Copy link
Contributor Author

How had I never noticed that run time at the right there?

@brockboland
Copy link
Contributor Author

See #123

@brockboland brockboland deleted the try_pod_lib_lint branch January 23, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants