feature/swift5 #135
Merged
feature/swift5 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
May 17, 2019 14:20
khaptonstall
force-pushed
the
feature/swift5
branch
2 times, most recently
from
fa3e42e
to
c6d0d0b
Compare
bryanluby
approved these changes
Jun 10, 2019
|
Tagged and pushed to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Made the following updates for Swift 5.0 support:
.travis.yml:Vokoder.podspecPaging Data Source Example,SampleProject, andSwiftSampleProjectpod installto update Vokoder versionAlso removed "deprecated" methods in
VOKCoreDataManager+Swift.swift. Quoting "deprecated" as they were marked@available(*, deprecated: 4.1.0, message: "use managedObject(ofClass:inContext:) instead")where4.1.0was meant to signify the podpsec version, but the@availableattribute knows nothing about the podspec version, so the compiler actually interpreted that as "Deprecated on all platforms of version 4.1.0". Now, in Swift 5, that throws a compiler warning since no platform is specified. I just removed the methods altogether since they've been "deprecated" for multiple version releases now, but if it would be preferred to leave them in, I'd either need to make the deprecation based on a Swift language version or for specific versions of each platform (iOS, macOS, tvOS)