Align DOM observer registration with PHP 8.5 and add PHP 8.5 CI validation

[Copilot]

• Inspect the new PR comments and verify whether they require code changes
• Update the exception messages in HtmlMin to match the current method names
• Adjust the targeted regression tests to assert the new messages
• Run targeted validation and security review for the follow-up change

---

This change is 

[coveralls]

coverage: 95.68% (-0.05%) from 95.727% — copilot/fix-deprecated-method-in-htmlmin into master

[voku]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a configuration for Infection mutation testing and strengthens static analysis by removing the exclusion for missing iterable value types in PHPStan. The HtmlMin class has been updated with more precise type annotations, additional null checks for node values, and improved validation for template logic and special script tags. Review feedback suggests aligning exception messages with their respective method names in the newly added validation logic to improve maintainability.

[gemini-code-assist]

The exception message refers to setTemplateLogicSyntaxInSpecialScriptTags, but the method name is overwriteTemplateLogicSyntaxInSpecialScriptTags. It is recommended to update the message to match the method name for better clarity and maintainability.

                throw new \InvalidArgumentException('overwriteTemplateLogicSyntaxInSpecialScriptTags only allows string[]');

[gemini-code-assist]

The exception message could be updated to match the method name overwriteSpecialScriptTags for consistency.

                throw new \InvalidArgumentException('overwriteSpecialScriptTags only allows string[]');

[voku]

@copilot the next llm generated feedback is maybe completely shot or not, you need to check if by yourself : Code Review
This pull request introduces a configuration for Infection mutation testing and strengthens static analysis by removing the exclusion for missing iterable value types in PHPStan. The HtmlMin class has been updated with more precise type annotations, additional null checks for node values, and improved validation for template logic and special script tags. Review feedback suggests aligning exception messages with their respective method names in the newly added validation logic to improve maintainability.

src/voku/helper/HtmlMin.php
$validatedTemplateLogicSyntaxInSpecialScriptTags = [];
foreach ($templateLogicSyntaxInSpecialScriptTags as $tmp) {
if (!\is_string($tmp)) {
throw new \InvalidArgumentException('setTemplateLogicSyntaxInSpecialScriptTags only allows string[]');
@gemini-code-assist
gemini-code-assist Bot
21 minutes ago
medium

The exception message refers to setTemplateLogicSyntaxInSpecialScriptTags, but the method name is overwriteTemplateLogicSyntaxInSpecialScriptTags. It is recommended to update the message to match the method name for better clarity and maintainability.

            throw new \InvalidArgumentException('overwriteTemplateLogicSyntaxInSpecialScriptTags only allows string[]');

@voku Reply...
src/voku/helper/HtmlMin.php
$validatedSpecialScriptTags = [];
foreach ($specialScriptTags as $tag) {
if (!\is_string($tag)) {
throw new \InvalidArgumentException('SpecialScriptTags only allows string[]');
@gemini-code-assist
gemini-code-assist Bot
21 minutes ago
medium

The exception message could be updated to match the method name overwriteSpecialScriptTags for consistency.

            throw new \InvalidArgumentException('overwriteSpecialScriptTags only allows string[]');

[Copilot]

@copilot the next llm generated feedback is maybe completely shot or not, you need to check if by yourself : Code Review
This pull request introduces a configuration for Infection mutation te...

Updated in f94d668. I aligned both exception messages with the actual method names and adjusted the regression tests accordingly.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud