Fix web converter samples and clear CI lint noise#4
Merged
Conversation
Agent-Logs-Url: https://github.com/voku/typeDiagram/sessions/eeef7fc0-c891-4210-a6b8-bc443be01ce5 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/typeDiagram/sessions/eeef7fc0-c891-4210-a6b8-bc443be01ce5 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/typeDiagram/sessions/eeef7fc0-c891-4210-a6b8-bc443be01ce5 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
voku
April 18, 2026 13:34
View session
Owner
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the DOM element mounting logic in converter-main.ts and main.ts to use instanceof HTMLElement checks while removing error logging for missing elements. It significantly expands the sample code for Python and PHP in converter.ts to include more complex types such as Enums, nullable fields, and new data structures like ChatTurnInput and UriPart. Additionally, it exports these samples and introduces a new test suite, converter-samples.test.ts, to ensure that the seed content remains parseable and convertible across all supported languages. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Removes the remaining web-entry lint noise and fixes the converter page’s shipped sample inputs so the examples align with the current converters and CI passes cleanly.
Details
CI failures
console.errorfallback branches from the web entrypoints (main.ts,converter-main.ts) that were surfacing asno-consolewarnings in CI.Converter page samples
Regression coverage
packages/web/test/converter-samples.test.tsto verify:TD_SAMPLEparses and builds,How Do The Automated Tests Prove It Works?
make cireproduces the failing path from the issue and now completes cleanly through format check, lint, test, build, and bundle-size.packages/web/test/converter-samples.test.tsexercises the actual shipped converter samples and verifies they remain parseable / convertible across supported languages.npm run -w packages/web testcovers the converter UI seed content alongside the existing converter page and render pipeline tests.