New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Support #83

Closed
jojomi opened this Issue Jan 5, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@jojomi
Copy link
Contributor

jojomi commented Jan 5, 2017

If I am not mistaken in the README.md, there is no support for SQLite. Is there plans to add it or is there conceptual problems with it?

@nullbio

This comment has been minimized.

Copy link
Member

nullbio commented Jan 6, 2017

If there is a lot of demand for this we can look into it further. From our initial assessments it does seem possible. I'll leave this thread open so we can gauge interest.

@aarondl

This comment has been minimized.

Copy link
Member

aarondl commented Jan 6, 2017

@jojomi I wanted to add some more concrete wording around this issue. SQLite is not on the roadmap currently and we don't have a need for it so we won't be implementing it UNLESS there's a huge demand by the community surrounding sqlboiler (like there was for mysql). It 'should' be possible as it's very similar to mysql.

If anyone would like to pursue this path, the first step is always creating a driver in the file bdb/drivers/sqlite.go and ensuring that for similar schemas similar output is achieved. --debug can be used to create a schema dump and you can diff them to ensure two database drivers create the same data for the same schema.

Thanks for bringing this up :)

@aarondl aarondl added the question label Jan 6, 2017

@jojomi

This comment has been minimized.

Copy link
Contributor

jojomi commented Jan 6, 2017

Thank your for the great tool, I imagine it is a lot of effort, but it sounds like just the thing you would need to have to implement database access in a golang way without being overly repetitive and verbose.

Also thank you for describing what one would have to do to implement a new driver, this might be README.md material :)

@nullbio nullbio removed the question label Jan 9, 2017

@robks

This comment has been minimized.

Copy link

robks commented Apr 6, 2017

It's better to focus on the big two DBs, yes, but SQLite is good for keeping some data offline - like notes. Thanks for this marvelous work!

@nullbio

This comment has been minimized.

Copy link
Member

nullbio commented Apr 7, 2017

@robks Yeah, we'll need to change the way we handle database drivers before we implement sqlite3 support because the driver requires some manual compilation and dependency steps on Windows, and we don't want SQLBoiler to break on all Windows users if they aren't even using sqlite3 to begin with. It is something we want to have eventually though.

@aarondl

This comment has been minimized.

Copy link
Member

aarondl commented Nov 14, 2017

This work is complete in the v3 branch and sqlite support can be built on top of it. There is still some breaking changes coming though I think a large majority of them that would affect drivers in any large way are done.

@aarondl

This comment has been minimized.

Copy link
Member

aarondl commented Jan 2, 2019

This is done for a while now.

@aarondl aarondl closed this Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment