Fix proportion OverusedFn overused logic #1116
Conversation
fix-bug: #1115 Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zen-xu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note: This pr need #1036 fix first |
Travis tests have failedHey @zen-xu, TravisBuddy Request Identifier: ddba5580-1887-11eb-86f8-31dd4df69769 |
| @@ -242,7 +242,7 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) { | |||
| queue := obj.(*api.QueueInfo) | |||
| attr := pp.queueOpts[queue.UID] | |||
|
|
|||
| overused := !attr.allocated.LessEqual(attr.deserved) | |||
| overused := !attr.allocated.Less(attr.deserved) | |||
Thor-wl
Oct 29, 2020
Collaborator
Please make CI happy
Please make CI happy
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Perhaps you need to go format the code |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
fix-bug: #1115
Signed-off-by: ZhengYu, Xu zen-xu@outlook.com