Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proportion OverusedFn overused logic #1116

Closed
wants to merge 1 commit into from
Closed

Conversation

@zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Oct 27, 2020

fix-bug: #1115

Signed-off-by: ZhengYu, Xu zen-xu@outlook.com

fix-bug: #1115
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@volcano-sh-bot
Copy link
Collaborator

@volcano-sh-bot volcano-sh-bot commented Oct 27, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zen-xu
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zen-xu
Copy link
Contributor Author

@zen-xu zen-xu commented Oct 27, 2020

Note: This pr need #1036 fix first

@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 27, 2020

Travis tests have failed

Hey @zen-xu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ddba5580-1887-11eb-86f8-31dd4df69769
@@ -242,7 +242,7 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
queue := obj.(*api.QueueInfo)
attr := pp.queueOpts[queue.UID]

overused := !attr.allocated.LessEqual(attr.deserved)
overused := !attr.allocated.Less(attr.deserved)

This comment has been minimized.

@Thor-wl

Thor-wl Oct 29, 2020
Collaborator

Please make CI happy

This comment has been minimized.

@zen-xu

zen-xu Oct 29, 2020
Author Contributor

#1036 lead the CI failed, so need to fix it first.

@stale
Copy link

@stale stale bot commented Dec 28, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale label Dec 28, 2020
@Thor-wl Thor-wl closed this Dec 30, 2020
@Thor-wl Thor-wl reopened this Dec 30, 2020
@stale stale bot removed the lifecycle/stale label Dec 30, 2020
@Thor-wl
Copy link
Collaborator

@Thor-wl Thor-wl commented Dec 31, 2020

Perhaps you need to go format the code

@stale
Copy link

@stale stale bot commented Mar 1, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale label Mar 1, 2021
@zen-xu zen-xu closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants