Skip to content

feat: Add securityContext support at container level in helm chart templates#3704

Merged
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
lekaf974:feat/add-security-context-helm-charts
Sep 10, 2024
Merged

feat: Add securityContext support at container level in helm chart templates#3704
volcano-sh-bot merged 1 commit intovolcano-sh:masterfrom
lekaf974:feat/add-security-context-helm-charts

Conversation

@lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Sep 2, 2024

Fix #3685

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2024
@lekaf974 lekaf974 marked this pull request as draft September 2, 2024 14:54
@lekaf974 lekaf974 marked this pull request as ready for review September 2, 2024 15:20
hwdef
hwdef reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should securityContext be added to scheduler and controller, and support setting different securityConetxt for admission, scheduler and controller?

@Monokaix
Copy link
Member

Monokaix commented Sep 3, 2024

Should securityContext be added to scheduler and controller, and support setting different securityConetxt for admission, scheduler and controller?

+1
The original issue mentioned that controller and scheduler also need csc: )

@lekaf974
Copy link
Contributor Author

lekaf974 commented Sep 4, 2024

Perfect will add changes for the scheduler

@lekaf974
Copy link
Contributor Author

lekaf974 commented Sep 4, 2024 •
edited
Loading

I split csc with a value for admission and another for scheduler

@lekaf974 lekaf974 force-pushed the feat/add-security-context-helm-charts branch 2 times, most recently from f947809 to d5000e3 Compare September 5, 2024 00:27
@googs1025
Copy link
Member

googs1025 commented Sep 5, 2024

ci may fail. We are trying to fix it in this PR. Sorry for the inconvenience. :)

Monokaix
Monokaix reviewed Sep 5, 2024
View reviewed changes
installer/helm/chart/volcano/values.yaml Outdated
# runAsUser: 2000
admission_default_csc: ~

# Specify container security context for scheduler
Copy link
Member

@Monokaix Monokaix Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put these admission_default_csc: ~ and scheduler_default_csc: ~ together.

Copy link
Contributor Author

@lekaf974 lekaf974 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean using the same definition for both ?

Copy link
Contributor Author

@lekaf974 lekaf974 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot about it, I saw how other fields were made so I'll follow the same behavior

Copy link
Contributor Author

@lekaf974 lekaf974 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@Monokaix Monokaix Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and please also squash it to one commit.

@Monokaix
Copy link
Member

Monokaix commented Sep 5, 2024

controller is also needed: )

@lekaf974
Copy link
Contributor Author

lekaf974 commented Sep 5, 2024

ci may fail. We are trying to fix it in this PR. Sorry for the inconvenience. :)

something similar to #3708

@lekaf974
Copy link
Contributor Author

lekaf974 commented Sep 5, 2024

controller is also needed: )

Done

@Monokaix
Copy link
Member

Monokaix commented Sep 5, 2024

Please also squash it to one commit: )

@lekaf974 lekaf974 force-pushed the feat/add-security-context-helm-charts branch from 8c01eb0 to 83bba02 Compare September 6, 2024 21:00
@lekaf974
Copy link
Contributor Author

lekaf974 commented Sep 6, 2024

Please also squash it to one commit: )

Done

@lekaf974 lekaf974 force-pushed the feat/add-security-context-helm-charts branch from 83bba02 to 65c4a7a Compare September 6, 2024 21:13
@lekaf974
feat: Add securityContext support at container level in helm chart te…
28c7a24 
…mplates

Security context added on:
- admission deployment
- admission-init job
- scheduler deployment
- controller deployment

Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 force-pushed the feat/add-security-context-helm-charts branch from 65c4a7a to 28c7a24 Compare September 9, 2024 01:49
hwdef
hwdef reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@lekaf974 lekaf974 requested a review from Monokaix September 9, 2024 11:42
@Monokaix
Copy link
Member

Monokaix commented Sep 10, 2024

/approve

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@volcano-sh-bot volcano-sh-bot merged commit fb61314 into volcano-sh:master Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@william-wang william-wang Awaiting requested review from william-wang

@Monokaix Monokaix Awaiting requested review from Monokaix

1 more reviewer

@hwdef hwdef hwdef left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hwdef hwdef

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add securityContext support at container level in helm chart templates

5 participants

@lekaf974 @Monokaix @googs1025 @volcano-sh-bot @hwdef