Repository navigation
skip the jobs that have no tasks during the close session step in gang plugin - #4012
Merged
Merged
Conversation
volcano-sh-bot
added
kind/flake
volcano-sh-bot
added
the
size/M
Wang-Kai
changed the title
volcano-sh-bot
added
size/XS
Signed-off-by: 王凯 <wangkai05@bilibili.com>
Wang-Kai
force-pushed
the
skip-unavailable-job
branch
from
February 17, 2025 13:34
0a48e4f to
15ebb45
Compare
Wang-Kai
changed the title
volcano-sh-bot
added
ok-to-test
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
/area scheduling
What this PR does / why we need it:
In the
OnSessionClosefunction, the new PR skip the unavailable job. Unnecessary podgroup condition updates are avoided in the following scenarios:len(jobInfo.Tasks) == 0 && jobInfo.PodGroup != nil, and a new PodGroupUnschedulableType condition is addedWhich issue(s) this PR fixes:
Fixes #4011
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
NONE