Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gomod to manage dependencies. #745

Merged
merged 1 commit into from Mar 24, 2020
Merged

Conversation

@tizhou86
Copy link
Contributor

tizhou86 commented Mar 24, 2020

Use gomod to manage dependencies.

@tizhou86

This comment has been minimized.

Copy link
Contributor Author

tizhou86 commented Mar 24, 2020

/assign @k82cn

@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Mar 24, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm label Mar 24, 2020
@volcano-sh-bot

This comment has been minimized.

Copy link
Collaborator

volcano-sh-bot commented Mar 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, tizhou86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 92db603 into volcano-sh:master Mar 24, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
tide In merge pool.
Details
@k82cn

This comment has been minimized.

Copy link
Member

k82cn commented Mar 24, 2020

@tizhou86 , should we remove dep config files?

@tizhou86

This comment has been minimized.

Copy link
Contributor Author

tizhou86 commented Mar 25, 2020

we can keep it for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.