Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Adding final to some constants - Findbugs

  • Loading branch information...
commit 24b21fa0bff36fd3308efbaad008d295abf9871b 1 parent 16387be
@rsumbaly rsumbaly authored afeinberg committed
View
6 src/java/voldemort/routing/RoutingStrategyType.java
@@ -7,9 +7,9 @@
*/
public class RoutingStrategyType {
- public static String CONSISTENT_STRATEGY = "consistent-routing";
- public static String TO_ALL_STRATEGY = "all-routing";
- public static String ZONE_STRATEGY = "zone-routing";
+ public final static String CONSISTENT_STRATEGY = "consistent-routing";
+ public final static String TO_ALL_STRATEGY = "all-routing";
+ public final static String ZONE_STRATEGY = "zone-routing";
private final String name;
View
2  src/java/voldemort/server/scheduler/slop/RepairJob.java
@@ -32,7 +32,7 @@
private final static Logger logger = Logger.getLogger(RepairJob.class.getName());
- public static List<String> blackList = Arrays.asList("mysql", "krati", "read-only");
+ public final static List<String> blackList = Arrays.asList("mysql", "krati", "read-only");
private final Semaphore repairPermits;
private final StoreRepository storeRepo;
View
2  src/java/voldemort/store/views/ViewStorageConfiguration.java
@@ -19,7 +19,7 @@
public class ViewStorageConfiguration implements StorageConfiguration {
- public static String TYPE_NAME = "view";
+ public final static String TYPE_NAME = "view";
private StoreRepository storeRepo;
private List<StoreDefinition> storeDefs;
View
3  src/java/voldemort/utils/RebalanceUtils.java
@@ -51,7 +51,8 @@
private static Logger logger = Logger.getLogger(RebalanceUtils.class);
- public static List<String> rebalancingStoreEngineBlackList = Arrays.asList("mysql", "krati");
+ public final static List<String> rebalancingStoreEngineBlackList = Arrays.asList("mysql",
+ "krati");
public static boolean containsNode(Cluster cluster, int nodeId) {
try {
Please sign in to comment.
Something went wrong with that request. Please try again.